SequenceComparer: Optimize by using SequenceEqual#12356
Merged
ScarletKuro merged 4 commits intoMudBlazor:devfrom Dec 26, 2025
Merged
SequenceComparer: Optimize by using SequenceEqual#12356ScarletKuro merged 4 commits intoMudBlazor:devfrom
ScarletKuro merged 4 commits intoMudBlazor:devfrom
Conversation
d26b7fe to
befb257
Compare
3 tasks
This was referenced Feb 20, 2026
Open
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's faster as it checks for
ICollection,IList, also checks if it can use spans in case of primitive types etc.Also improved
CollectionComparer.GetHashCode.The old implementation used
Distinct+OrderBy+ a combiner to normalize hash codes:O(n log n)time.The new implementation avoids sorting:
It directly matches the documented semantics:
MudBlazor/src/MudBlazor/Utilities/Comparer/CollectionComparer.cs
Line 8 in c9c23d5
So the new
GetHashCodeis simpler, faster, and fully correct for the intended behavior.Checklist: