DebounceDispatcher: Fix race condition causing flaky test#12334
Merged
ScarletKuro merged 2 commits intodevfrom Dec 21, 2025
Merged
DebounceDispatcher: Fix race condition causing flaky test#12334ScarletKuro merged 2 commits intodevfrom
ScarletKuro merged 2 commits intodevfrom
Conversation
Co-authored-by: ScarletKuro <[email protected]>
Copilot
AI
changed the title
[WIP] Fix flakiness in debounce async test
Fix race condition in DebounceDispatcher causing flaky test
Dec 21, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a race condition in DebounceDispatcher that caused the DebounceAsync_LeadingMode_DebounceSubsequentCalls test to fail intermittently with incorrect execution counts.
Key Changes
- Race condition fix: Moved
CancellationTokenSourcecapture inside the lock to prevent concurrent calls from capturing the same instance - Test improvement: Changed from fire-and-forget pattern with
Task.Delayto explicitly storing and awaiting task references for proper synchronization
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/MudBlazor/Utilities/Debounce/DebounceDispatcher.cs |
Declares localCts at method scope and captures the CancellationTokenSource reference inside the lock before release, preventing race conditions where multiple concurrent calls could capture the same instance |
src/MudBlazor.UnitTests/Utilities/Debounce/DebounceDispatcherTests.cs |
Stores task references from concurrent DebounceAsync calls and explicitly awaits them, replacing the fire-and-forget pattern with Task.Delay to eliminate timing assumptions and ensure proper test synchronization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 20, 2026
Open
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DebounceAsync_LeadingMode_DebounceSubsequentCallstest was flaky, failing intermittently with execution count of 3 instead of expected 2.Root Cause
Race condition in
DebounceDispatcher.cs: theCancellationTokenSourcewas captured outside the lock, allowing multiple concurrent calls to capture the same instance.Changes
Implementation (
DebounceDispatcher.cs)localCtsat method scopeTest (
DebounceDispatcherTests.cs)Task.Delay(150)Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.