MudDialog: Prevent default on close button to not trigger validations#12332
Merged
danielchalmers merged 2 commits intoMudBlazor:devfrom Jan 11, 2026
Merged
Conversation
mudbot
bot
changed the title
mudbot
bot
added
the
bug
Contributor
|
The change is simple enough and I do approve. Is there any way to add a test to protect this change in the future. |
versile2
approved these changes
Dec 23, 2025
Contributor
versile2
left a comment
versile2
left a comment
There was a problem hiding this comment.
I would like to see a test for this if possible, but this is a simple change without any downside I can find.
danielchalmers
added
the
needs: tests
spingee
force-pushed
the
feature/dialog_prevent_default
branch
from
0bb0e7d to
3790756
Compare
Contributor
Author
|
@versile2 i have added test |
Member
|
Thank you! |
This was referenced Feb 20, 2026
Open
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is small one.
When there is form with validated fields in dialog, closing dialog will trigger validations on focused input resulting in brief red noise.