MudBaseInput: Remove TextUpdateSuppression#12306
Merged
ScarletKuro merged 3 commits intoMudBlazor:devfrom Dec 19, 2025
Merged
Conversation
…eFormat - Removed TextUpdateSuppression parameter from MudBaseInput - Removed all conditional logic that checked TextUpdateSuppression - Text now always updates when Value changes (no suppression) - Updated all component templates to remove TextUpdateSuppression attribute - Updated tests to reflect new behavior (text always updates) - Removed documentation about TextUpdateSuppression - NumericFieldTestCultureFormat now passes on .NET 10! - SelectTest1 still failing (investigating) Co-authored-by: ScarletKuro <[email protected]>
mudbot
bot
added
breaking change
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the TextUpdateSuppression feature from MudBaseInput and all derived components, simplifying the internal text update logic to always update the text when values change, regardless of focus state or runtime location (Blazor Server vs WASM).
Key Changes:
- Removed the
TextUpdateSuppressionparameter fromMudBaseInputand all component usages - Simplified text update logic in
MudBaseInputandMudInputby removing conditional checks for focus state and runtime location - Updated tests to reflect the new always-update behavior
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/MudBlazor/Base/MudBaseInput.cs | Removed TextUpdateSuppression parameter definition and simplified text update logic in SetParametersAsync and OnValueParameterChangedAsync |
| src/MudBlazor/Components/Input/MudInput.razor.cs | Simplified SetParametersAsync to always update _internalText without conditional logic |
| src/MudBlazor/Components/TextField/MudTextField.razor | Removed TextUpdateSuppression parameter from two MudInput component usages |
| src/MudBlazor/Components/Select/MudSelect.razor | Removed TextUpdateSuppression="false" from MudInput usage |
| src/MudBlazor/Components/Picker/MudPicker.razor | Removed TextUpdateSuppression with dynamic value from MudInputControl usage |
| src/MudBlazor/Components/NumericField/MudNumericField.razor | Removed TextUpdateSuppression parameter from MudInput usage |
| src/MudBlazor/Components/Autocomplete/MudAutocomplete.razor | Removed TextUpdateSuppression parameter from MudInput usage |
| src/MudBlazor/Components/Mask/MudMask.razor.cs | Removed TextUpdateSuppression = false assignment from constructor |
| src/MudBlazor.UnitTests/Components/TextFieldTests.cs | Updated test to verify new always-update behavior instead of suppression logic |
| src/MudBlazor.UnitTests/Components/AutocompleteTests.cs | Removed TextUpdateSuppression parameter setting and updated comment |
| src/MudBlazor.Docs/Pages/Components/TextField/TextFieldPage.razor | Removed documentation alert about TextUpdateSuppression parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 20, 2026
Closed
Open
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist: