Skip to content

MudBaseInput: ParameterState for Value#12267

Merged
ScarletKuro merged 4 commits intodevfrom
base_value
Dec 14, 2025
Merged

MudBaseInput: ParameterState for Value#12267
ScarletKuro merged 4 commits intodevfrom
base_value

Conversation

@ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Dec 13, 2025

Checklist:

  • I've read the contribution guidelines
  • My code follows the style of this project
  • I've added or updated relevant unit tests

@ScarletKuro
Copy link
Member Author

ScarletKuro commented Dec 13, 2025

@copilot
We are migrating MudBaseInput.Value to use parameter state same way we did in #12259 and #12244 (context issue #12243)
But 3 tests are failing now, which wasn't failing before those changes. Figure out why and fix it.

Copilot AI mentioned this pull request Dec 13, 2025
Merged
3 tasks
Copy link
Contributor

Copilot AI commented Dec 13, 2025

@ScarletKuro I've opened a new pull request, #12268, to work on those changes. Once the pull request is ready, I'll request review from you.

ScarletKuro and others added 2 commits December 14, 2025 03:11
@ScarletKuro
Merge branch 'dev' into base_value
1790106
@ScarletKuro
MudBaseInput: ParameterState for Value (#12268)
5bdf7dd 
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: ScarletKuro <[email protected]>
Co-authored-by: Artyom M. <[email protected]>
@ScarletKuro ScarletKuro marked this pull request as ready for review December 14, 2025 02:04
@ScarletKuro ScarletKuro merged commit 2e3f97c into dev Dec 14, 2025
9 checks passed
@ScarletKuro ScarletKuro deleted the base_value branch December 14, 2025 02:09
@ScarletKuro ScarletKuro added breaking change This change will require consumer code updates refactor Reorganizes code and has no changes to the API or functionality in the main library labels Dec 14, 2025
@ScarletKuro ScarletKuro mentioned this pull request Dec 22, 2025
Merged
3 tasks
Copilot AI mentioned this pull request Dec 22, 2025
Closed
10 tasks
This was referenced Feb 20, 2026
Merged
Closed
Open
Closed
Open
Merged
Closed
Merged
Open
Closed
Open
Closed
Closed
Open
Open
Open
This was referenced Feb 23, 2026
Open
Open
Open
Open
Open
Open
Open
@rasmus-carlsson rasmus-carlsson mentioned this pull request Feb 23, 2026
Merged
This was referenced Feb 23, 2026
Open
Open
Open
Closed
Merged
Closed
Open
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Open
Open
Closed
Open
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking change This change will require consumer code updates refactor Reorganizes code and has no changes to the API or functionality in the main library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ScarletKuro