Skip to content

Adjust namespaces to file scoped#12260

Closed
91378246 wants to merge 1 commit intoMudBlazor:devfrom
91378246:namespaces-to-file-scoped
Closed

Adjust namespaces to file scoped#12260
91378246 wants to merge 1 commit intoMudBlazor:devfrom
91378246:namespaces-to-file-scoped

Conversation

@91378246
Copy link
Contributor

This PR changes all namespace declarations in the MudBlazor project to the state of the art file scoped variant.

Note that this is intentionally only for the MudBlazor project to keep the file count somewhat manageable. I will also provide PRs for the other projects if this PR is accepted.

@91378246 91378246 marked this pull request as ready for review December 12, 2025 15:49
@91378246
Copy link
Contributor Author

Will fix pipeline once I got feedback whether this is wanted or not

@ScarletKuro
Copy link
Member

Sorry, but we deliberately decided not to do that. It interferes with git blame and git bisect, making it harder to track down regressions.

We agreed that this kind of change should only be applied to new files, simple files with minimal logic, or very stable and tested part of the code.

For the rest, Mud isn’t stable enough to justify doing this refactor in bulk.
Id rather redo components one by one, like Validation, new inputs components, to switch majority of files to scoped namespace.

@91378246
Copy link
Contributor Author

@ScarletKuro Ah okay, just thought it would be better in bulk as it makes the diffs very hard to read when you change the namespace to the file scope variant.

@91378246 91378246 closed this Dec 12, 2025
@91378246 91378246 deleted the namespaces-to-file-scoped branch December 12, 2025 16:14
@ScarletKuro
Copy link
Member

Also. forgot to mention that it instantly makes other PRs to have conflicts, and it's too hard too to solve them via editor that you can basically just throw the work and start over manually.

@danielchalmers danielchalmers added the refactor Reorganizes code and has no changes to the API or functionality in the main library label Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Reorganizes code and has no changes to the API or functionality in the main library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants