Skip to content

Popovers: Remove and Replace DropdownSettings#12186

Merged
danielchalmers merged 11 commits intoMudBlazor:devfrom
versile2:popover/remove_dropdownsettings_issue_12043
Dec 5, 2025
Merged

Popovers: Remove and Replace DropdownSettings#12186
danielchalmers merged 11 commits intoMudBlazor:devfrom
versile2:popover/remove_dropdownsettings_issue_12043

Conversation

@versile2
Copy link
Contributor

@versile2 versile2 commented Dec 2, 2025

Per #12043 remove DropdownSettings and replace with individual parameters
Replaces #12185
Separate PR will be for Overflow Padding after this PR is merged
Updated Popover Docs section

Migration:

Caution

DropdownSettings has been removed. MudSelect, MudMenu, and MudAutocomplete now all contain PopoverFixed and OverflowBehavior as a replacement.

MudGlobal.PopoverDefaults.OverflowBehavior: OveflowBehavior can now be set in MudGlobal allowing a set once and forget parameter.

Screenshot 2025-12-02 095303

Checklist:

  • I've read the contribution guidelines
  • My code follows the style of this project
  • I've added or updated relevant unit tests

@mudbot mudbot bot added API change Modifies the public API surface breaking change This change will require consumer code updates enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library labels Dec 2, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the DropdownSettings struct and replaces it with individual PopoverFixed and OverflowBehavior parameters across components that use dropdown popovers (MudSelect, MudMenu, MudAutocomplete). A new global default MudGlobal.PopoverDefaults.OverflowBehavior is introduced to centralize the default overflow behavior configuration.

Key Changes:

  • Removed DropdownSettings struct and replaced with separate PopoverFixed and OverflowBehavior parameters
  • Added MudGlobal.PopoverDefaults.OverflowBehavior for centralized default configuration
  • Updated documentation and examples to reflect the new API

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
MudGlobal.cs Adds new static property OverflowBehavior to PopoverDefaults for global default configuration
MudSelect.razor.cs Replaces DropdownSettings parameter with individual PopoverFixed and OverflowBehavior parameters
MudSelect.razor Updates popover bindings to use new individual parameters instead of DropdownSettings
DropDownSettings.cs Removes the entire DropdownSettings struct file
MudMenu.razor.cs Replaces DropdownSettings parameter with individual PopoverFixed and OverflowBehavior parameters
MudMenu.razor Updates popover bindings to use new individual parameters
MudAutocomplete.razor.cs Replaces DropdownSettings parameter with individual PopoverFixed and OverflowBehavior parameters
MudAutocomplete.razor Updates popover bindings to use new individual parameters
SelectTests.cs Adds tests verifying default values and override behavior for the new parameters
PopoverTests.cs Removes obsolete tests for the deleted DropdownSettings struct
MenuTests.cs Adds tests verifying default values and override behavior for the new parameters
AutocompleteTests.cs Adds tests verifying default values and override behavior for the new parameters
PopoverFlipDirectionTest.razor Updates test component to use OverflowBehavior parameter directly
MenuFlipTest.razor Updates test component to use OverflowBehavior parameter directly
Appbar.razor.cs Removes unused DropdownSettings field
Appbar.razor Updates autocomplete to use PopoverFixed parameter
PopoverPage.razor Updates documentation to reflect the new individual parameter approach
PopoverDropdownSettingsExample.razor Updates example to demonstrate individual parameters instead of DropdownSettings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This was referenced Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change Modifies the public API surface breaking change This change will require consumer code updates enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants