Popovers: Remove and Replace DropdownSettings#12186
Merged
danielchalmers merged 11 commits intoMudBlazor:devfrom Dec 5, 2025
Merged
Popovers: Remove and Replace DropdownSettings#12186danielchalmers merged 11 commits intoMudBlazor:devfrom
danielchalmers merged 11 commits intoMudBlazor:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the DropdownSettings struct and replaces it with individual PopoverFixed and OverflowBehavior parameters across components that use dropdown popovers (MudSelect, MudMenu, MudAutocomplete). A new global default MudGlobal.PopoverDefaults.OverflowBehavior is introduced to centralize the default overflow behavior configuration.
Key Changes:
- Removed
DropdownSettingsstruct and replaced with separatePopoverFixedandOverflowBehaviorparameters - Added
MudGlobal.PopoverDefaults.OverflowBehaviorfor centralized default configuration - Updated documentation and examples to reflect the new API
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| MudGlobal.cs | Adds new static property OverflowBehavior to PopoverDefaults for global default configuration |
| MudSelect.razor.cs | Replaces DropdownSettings parameter with individual PopoverFixed and OverflowBehavior parameters |
| MudSelect.razor | Updates popover bindings to use new individual parameters instead of DropdownSettings |
| DropDownSettings.cs | Removes the entire DropdownSettings struct file |
| MudMenu.razor.cs | Replaces DropdownSettings parameter with individual PopoverFixed and OverflowBehavior parameters |
| MudMenu.razor | Updates popover bindings to use new individual parameters |
| MudAutocomplete.razor.cs | Replaces DropdownSettings parameter with individual PopoverFixed and OverflowBehavior parameters |
| MudAutocomplete.razor | Updates popover bindings to use new individual parameters |
| SelectTests.cs | Adds tests verifying default values and override behavior for the new parameters |
| PopoverTests.cs | Removes obsolete tests for the deleted DropdownSettings struct |
| MenuTests.cs | Adds tests verifying default values and override behavior for the new parameters |
| AutocompleteTests.cs | Adds tests verifying default values and override behavior for the new parameters |
| PopoverFlipDirectionTest.razor | Updates test component to use OverflowBehavior parameter directly |
| MenuFlipTest.razor | Updates test component to use OverflowBehavior parameter directly |
| Appbar.razor.cs | Removes unused DropdownSettings field |
| Appbar.razor | Updates autocomplete to use PopoverFixed parameter |
| PopoverPage.razor | Updates documentation to reflect the new individual parameter approach |
| PopoverDropdownSettingsExample.razor | Updates example to demonstrate individual parameters instead of DropdownSettings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
3 tasks
This was referenced Feb 20, 2026
Closed
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #12043 remove DropdownSettings and replace with individual parameters
Replaces #12185
Separate PR will be for Overflow Padding after this PR is merged
Updated Popover Docs section
Migration:
Caution
DropdownSettingshas been removed.MudSelect,MudMenu, andMudAutocompletenow all containPopoverFixedandOverflowBehavioras a replacement.MudGlobal.PopoverDefaults.OverflowBehavior:
OveflowBehaviorcan now be set inMudGlobalallowing a set once and forget parameter.Checklist: