ThemeProvider: Add `bind-CurrentPalette` parameter by Copilot · Pull Request #12149 · MudBlazor/MudBlazor

Copilot · 2025-11-23T19:58:09Z

Adds CurrentPalette parameter to MudThemeProvider for direct access to the active palette instance, automatically reflecting dark mode state.

Changes:

Added CurrentPalette parameter with CurrentPaletteChanged EventCallback for two-way binding
Implemented ParameterState-based management with async change handlers for IsDarkMode and Theme updates
Updated OnParametersSet() to OnParametersSetAsync() for proper async/await support
Added 9 unit tests covering palette switching, custom themes, and binding behavior

Usage:

<MudThemeProvider @bind-CurrentPalette="@currentPalette" />

@code {
    private Palette? currentPalette;
    
    // Direct access to current colors without checking IsDarkMode
    var primary = currentPalette?.Primary;
}

Eliminates need to manually select between PaletteLight and PaletteDark based on dark mode state.

Checklist:

I've read the contribution guidelines
My code follows the style of this project
I've added or updated relevant unit tests

Fixes #12109

Original prompt

This section details on the original issue you should resolve

<issue_title>Add bind-CurrentPalette to theme provider</issue_title>
<issue_description>### Describe your idea

Add a bind-CurrentPalette property to the theme provider so developers can directly access the palette instance currently being used, which automatically reflects whether dark mode is enabled or not. This binding would allow better real-time customization and inspection of theme colors, making dynamic theming easier and more robust in Blazor apps.

Example code and screenshots

Example usage:
<MudThemeProvider bind-CurrentPalette="@currentPalette">
  
</MudThemeProvider>
This would expose the current palette object for the theme (Primary, Secondary, etc.), allowing visibility and direct use depending on dark mode state without extra logic.
</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Add bind-CurrentPalette to theme provider #12109

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: danielchalmers <[email protected]>

…cumentation Co-authored-by: danielchalmers <[email protected]>

ScarletKuro · 2025-11-23T20:16:18Z

src/MudBlazor/Components/ThemeProvider/MudThemeProvider.razor.cs

+    private void UpdateCurrentPalette()
+    {
+        var newPalette = GetCurrentPalette();
+        _ = _currentPaletteState.SetValueAsync(newPalette);


Why it's fire and forget? it should be a task method UpdateCurrentPaletteAsync and the SetValueAsync should be awaited

@copilot Why it's fire and forget? it should be a task method UpdateCurrentPaletteAsync and the SetValueAsync should be awaited

Changed to async method UpdateCurrentPaletteAsync() and properly awaited. Also updated OnParametersSet() to OnParametersSetAsync() to support async operations. Fixed in commit d69e192.

ScarletKuro · 2025-11-23T20:17:11Z

src/MudBlazor.UnitTests/Components/ThemeProviderTests.cs

+            comp.Instance.GetState(x => x.CurrentPalette).Should().BeOfType<PaletteLight>();
+
+            // Act
+            await comp.InvokeAsync(() => comp.SetParametersAndRender(parameters => parameters


I don't think InvokeAsync is necessary for SetParametersAndRender

Removed unnecessary InvokeAsync wrappers around SetParametersAndRender calls in all affected tests. Fixed in commit d69e192.

ScarletKuro · 2025-11-23T20:17:46Z

src/MudBlazor/Components/ThemeProvider/MudThemeProvider.razor.cs


+    private async Task OnIsDarkModeChangedAsync(ParameterChangedEventArgs<bool> arg)
+    {
+        await _currentPaletteState.SetValueAsync(GetCurrentPalette());


Why just not retrun _currentPaletteState.SetValueAsync(GetCurrentPalette());?

Simplified to directly return the Task from SetValueAsync. Fixed in commit d69e192.

ScarletKuro · 2025-11-23T20:19:27Z

src/MudBlazor/Components/ThemeProvider/MudThemeProvider.razor.cs

        }

+        // Update CurrentPalette if theme changed or this is the first time
+        if (themeChanged || !_currentPaletteInitialized)


Explain me this part what are you doing here?

This initialization logic ensures CurrentPalette is set on component startup (first OnParametersSet call) and whenever the Theme property changes. The _currentPaletteInitialized flag tracks whether we've set the initial palette value, and we also update it when the theme reference changes. This prevents unnecessary updates on every parameter set while ensuring the palette is always current.

danielchalmers · 2025-11-23T20:21:24Z

@copilot respond to comments

mudbot · 2025-11-23T20:22:26Z

I've received the request to respond to the review comments. However, the specific feedback from the review is not accessible to me. Could you please summarize the required changes in a new comment? I'll address them once the details are available.

I'm an AI assistant — If I missed something or made a mistake, please let me know in a reply!

…Async Co-authored-by: danielchalmers <[email protected]>

…ider

ScarletKuro

For me, it's good to go now. Copilot over-complicated it, and some parts didn't make sense to me.
It's easier to do this job in OnParametersSetAsync. Even if unrelated parameters change, the parameter state won't do anything if GetCurrentPalette is the same as _currentPaletteState.Value, so it's actually safe to call it as often as you want.

Initial plan

7ff7e83

Copilot AI assigned Copilot and danielchalmers Nov 23, 2025

Copilot started work on behalf of danielchalmers November 23, 2025 19:58 View session

Copilot AI and others added 2 commits November 23, 2025 20:11

Add CurrentPalette binding to MudThemeProvider with comprehensive tests

6549136

Co-authored-by: danielchalmers <[email protected]>

Address code review feedback - add initialization flag and improve do…

77b4d0b

…cumentation Co-authored-by: danielchalmers <[email protected]>

ScarletKuro requested changes Nov 23, 2025

View reviewed changes

ScarletKuro reviewed Nov 23, 2025

View reviewed changes

Copilot AI changed the title ~~[WIP] Add bind-CurrentPalette to theme provider~~ Add bind-CurrentPalette to MudThemeProvider Nov 23, 2025

Copilot AI requested a review from danielchalmers November 23, 2025 20:22

Copilot finished work on behalf of danielchalmers November 23, 2025 20:22

mudbot bot added the needs: changes A maintainer has asked for further modifications to be made to this pull request label Nov 23, 2025

Copilot started work on behalf of danielchalmers November 23, 2025 20:22 View session

Address PR feedback - use async methods and remove unnecessary Invoke…

d69e192

…Async Co-authored-by: danielchalmers <[email protected]>

Copilot finished work on behalf of danielchalmers November 23, 2025 20:28

danielchalmers marked this pull request as ready for review November 23, 2025 20:35

mudbot bot changed the title ~~Add bind-CurrentPalette to MudThemeProvider~~ MudThemeProvider: Add bind-CurrentPalette parameter Nov 23, 2025

mudbot bot removed the needs: changes A maintainer has asked for further modifications to be made to this pull request label Nov 23, 2025

danielchalmers requested a review from Anu6is November 23, 2025 20:35

mudbot bot added the enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library label Nov 24, 2025

ScarletKuro added 3 commits November 25, 2025 13:07

Don't overcomplicate

592d021

Switch to IAsyncDisposable

a146f2b

Merge branch 'dev' into copilot/add-bind-currentpalette-to-theme-prov…

01ad37f

…ider

ScarletKuro approved these changes Nov 25, 2025

View reviewed changes

danielchalmers merged commit a47f81a into dev Nov 25, 2025
7 of 8 checks passed

ScarletKuro deleted the copilot/add-bind-currentpalette-to-theme-provider branch November 25, 2025 15:36

danielchalmers changed the title ~~MudThemeProvider: Add bind-CurrentPalette parameter~~ ThemeProvider: Add bind-CurrentPalette parameter Dec 20, 2025

dependabot bot mentioned this pull request Feb 20, 2026

Bump the open-source-license group with 11 updates GuyWhoKnowsTheGuy/megaschool1#151

Closed

Uh oh!

Conversation

Copilot AI commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Example code and screenshots

Comments on the Issue (you are @copilot in this section)

Uh oh!

ScarletKuro Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

danielchalmers Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

ScarletKuro Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

ScarletKuro Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

ScarletKuro Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

danielchalmers commented Nov 23, 2025

Uh oh!

mudbot bot commented Nov 23, 2025

Uh oh!

ScarletKuro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Nov 23, 2025 •

edited

Loading