Skip to content

Palette: Make PaletteLight and PaletteDark of type Palette#12148

Merged
danielchalmers merged 3 commits intoMudBlazor:devfrom
danielchalmers:simple-ostrich
Nov 23, 2025
Merged

Palette: Make PaletteLight and PaletteDark of type Palette#12148
danielchalmers merged 3 commits intoMudBlazor:devfrom
danielchalmers:simple-ostrich

Conversation

@danielchalmers
Copy link
Member

From #12089 and spun off #12092 for smaller pieces

Checklist:

  • I've read the contribution guidelines
  • My code follows the style of this project
  • I've added or updated relevant unit tests

@mudbot mudbot bot added the refactor Reorganizes code and has no changes to the API or functionality in the main library label Nov 23, 2025
@danielchalmers danielchalmers added API change Modifies the public API surface and removed refactor Reorganizes code and has no changes to the API or functionality in the main library labels Nov 23, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the MudTheme class to use the base Palette type for its theme palette properties instead of the concrete PaletteLight and PaletteDark types. This change improves the API design by making it more polymorphic while maintaining backward compatibility.

Key Changes

  • Changed PaletteLight property type from PaletteLight to Palette
  • Changed PaletteDark property type from PaletteDark to Palette

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danielchalmers danielchalmers merged commit 812e9c9 into MudBlazor:dev Nov 23, 2025
6 checks passed
@danielchalmers danielchalmers deleted the simple-ostrich branch November 23, 2025 20:18
@ScarletKuro ScarletKuro mentioned this pull request Feb 11, 2026
9 tasks
This was referenced Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change Modifies the public API surface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants