v9: Remove all code marked obsolete/deprecated#12142
Merged
danielchalmers merged 4 commits intodevfrom Nov 23, 2025
Merged
Conversation
Co-authored-by: danielchalmers <[email protected]>
Copilot
AI
changed the title
[WIP] Remove all obsolete and deprecated code for v9 release
v9: Remove all code marked obsolete/deprecated
Nov 23, 2025
danielchalmers
approved these changes
Nov 23, 2025
Member
|
Fix these formatting errors: And the failing ApiMemberTable_RenderGlobals_WhenExisting test from #12046 (check all tests) |
Co-authored-by: danielchalmers <[email protected]>
Contributor
Author
Fixed in c105375:
All tests now pass (5,265 total). |
Member
Fix those and add a part about running dotnet format to the AGENTS.md file so it doesn't happen again. |
Co-authored-by: danielchalmers <[email protected]>
Contributor
Author
|
... Fixed in e513a1f:
The formatting command is now documented as step 2 (before build) in the validation sequence to ensure it's always run before creating/updating PRs. |
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all
[Obsolete]marked code for v9 major release cleanup.Changes
Removed Methods:
DialogService/IDialogService: 10 synchronousShow()overloads → useShowAsync()MudTabs: 3ActivatePanel()overloads → useActivatePanelAsync()MudSelect:Clear()→ useClearAsync()MudDataGrid:ExpandAllGroups(),CollapseAllGroups()→ use async versionsElementReferenceExtensions:MudDetachBlurEventWithJS()MudMenu:Stylenameproperty → usePositionAttributesRemoved Files:
XmlDocumentation.cs(603 lines) - obsolete doc generator replaced byApiDocumentationBuilderExtracted Method:
TypeExtensions.ConvertToCSharpSource()- extracted from deleted XmlDocumentation class, still required byDefaultTheme.razorfor type displayDocumentation:
MudTimelineItem.IconMudTheme.PaletteLightAGENTS.mdwithdotnet formatvalidation step to prevent formatting issues in future PRsTests:
DialogTeststo useShowAsync()instead of deprecatedShow()ApiMemberTable_RenderGlobals_WhenExistingtest to useMudDialoginstead ofMudButton(globals were removed from MudButton in MudGlobal: Remove deprecated theming properties #12141)Migration Example:
Note:
_obsolete.scssretained - contains actively used utility classes (mud-width-full,mud-height-full,w-max) referenced 220+ times across codebase.Checklist:
Fixes #12048
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.