MudPopover: Fix JS Typo#11968
Merged
danielchalmers merged 3 commits intoMudBlazor:devfrom Oct 17, 2025
Merged
Conversation
mudbot
bot
added
the
bug
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a minor typo in the mudPopover.js file by adding a missing semicolon. This change improves code consistency and is a good practice to avoid potential issues with JavaScript's Automatic Semicolon Insertion. The change is correct and I approve of it.
Anu6is
approved these changes
Oct 17, 2025
… 0 not return falsy and skip to boundingRect.left.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fix aims to correct a missing semicolon and adjust how explicit position override values are resolved for the popover.
- Replaced logical OR (||) with nullish coalescing (??) for position override parsing.
- Added a missing semicolon after offsetY adjustment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
This was referenced Nov 5, 2025
Closed
This was referenced Dec 22, 2025
This was referenced Jan 3, 2026
This was referenced Jan 11, 2026
Closed
This was referenced Feb 5, 2026
Closed
This was referenced Feb 16, 2026
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typo in mudPopover.js file, forgotten semicolon. Added it.
Found a falsy check that should be a null check and swapped it.
Checklist:
dev).One character for the typo
Swapped || for ?? on two lines.
Verified other falsy checks shouldn't be invalid.