Skip to content

MudDialog: Fix when a dialog is canceled, it can be reopened#11804

Merged
ScarletKuro merged 2 commits intoMudBlazor:devfrom
vernou:11789-dialog-cancel-open
Aug 19, 2025
Merged

MudDialog: Fix when a dialog is canceled, it can be reopened#11804
ScarletKuro merged 2 commits intoMudBlazor:devfrom
vernou:11789-dialog-cancel-open

Conversation

@vernou
Copy link
Member

@vernou vernou commented Aug 18, 2025

Fixes #11789

This PR fixes the bug, where a dialog is canceled, it can't be reopened (need to be open two times to be displayed).

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the style of this project.
  • I've added relevant tests or tested on existing ones.

@vernou vernou self-assigned this Aug 18, 2025
@vernou vernou added the bug Unexpected behavior or functionality not working as intended label Aug 18, 2025
@vernou vernou force-pushed the 11789-dialog-cancel-open branch from ece14f3 to 3be3283 Compare August 18, 2025 22:22
@vernou vernou force-pushed the 11789-dialog-cancel-open branch from 3be3283 to 8cf2b87 Compare August 18, 2025 22:31
@sonarqubecloud
Copy link

@vernou vernou marked this pull request as ready for review August 18, 2025 22:55
@vernou vernou requested a review from versile2 August 18, 2025 22:59
Copy link
Contributor

@versile2 versile2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I verified the Dialogs continue to work the same with no side effects, the test fails without the change and passes with the change. Good work.

@vernou vernou requested a review from ScarletKuro August 19, 2025 16:44
@ScarletKuro ScarletKuro merged commit 8d329a8 into MudBlazor:dev Aug 19, 2025
6 checks passed
@ScarletKuro
Copy link
Member

Thanks, very good job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudDialog: Double-click required to reopen inline dialog after using the close button

3 participants