MudTextField: Fix padding for outlined multiline fields#11776
MudTextField: Fix padding for outlined multiline fields#11776danielchalmers merged 1 commit intoMudBlazor:devfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @rasmus-carlsson, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've addressed an issue where the padding for MudTextField outlined multiline fields was incorrectly applied. This was due to a misunderstanding of the CSS padding shorthand property when three values are provided, which inadvertently flipped the top/bottom and left/right padding in a previous change. This pull request corrects the order of these values to restore the intended visual layout and ensure consistent UI.
Highlights
- CSS Padding Correction: Corrected the
paddingproperty insrc/MudBlazor/Styles/components/_input.scssfrom0px 18.5px 14pxto0px 14px 18.5pxto properly apply top, left/right, and bottom padding for outlined multilineMudTextFieldcomponents. This resolves a visual bug introduced in a previous PR.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
github-actions
bot
added
the
bug
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a padding issue for outlined multiline text fields by swapping the horizontal and bottom padding values in the padding shorthand property. The change aligns with the component's styling for single-line inputs, restoring consistency. My review includes a suggestion to replace the hardcoded padding values with CSS variables to adhere to the project's style guide and improve maintainability.
|
|
@charles7668 @mathdx1111 do you want to check this out? |
charles7668
left a comment
charles7668
left a comment
There was a problem hiding this comment.
It looks fine, the padding size was significantly changed in #11402.
|
@danielchalmers merge this if you find this change appropriate. |
4 participants
Fix padding for outlined multiline fields
In #11402,
0pxwas added to the start of the rule, changingpadding: 12px 10px;topadding: 0px 12px 10px;. This flipped the padding since the shorthands work like this:top/bottom | left/righttop | left/right | bottomThis fix restores the intended padding by correcting the order.
Before
After
Repro
https://try.mudblazor.com/snippet/caQzkiuhBBijWPIg