Skip to content

MudDataGrid: AllowUnsorted Default Behavior #11655

Merged
danielchalmers merged 2 commits intoMudBlazor:devfrom
versile2:fix_datagrid_11443
Jul 15, 2025
Merged

MudDataGrid: AllowUnsorted Default Behavior #11655
danielchalmers merged 2 commits intoMudBlazor:devfrom
versile2:fix_datagrid_11443

Conversation

@versile2
Copy link
Contributor

PR #11443 added a new feature to AllowUnsorted and incorrectly set the default to true causing a Breaking Change. This reverts just the default behavior.

Checklist:

  • The PR is submitted to the correct branch (dev)
  • My code follows the code style of this project
  • I've added relevant tests

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended regression Previously worked and now doesn't breaking-change labels Jul 14, 2025
@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (9c12be4) to head (ff9ece2).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #11655      +/-   ##
==========================================
+ Coverage   91.31%   91.35%   +0.03%     
==========================================
  Files         466      466              
  Lines       14707    14697      -10     
  Branches     2857     2853       -4     
==========================================
- Hits        13430    13426       -4     
+ Misses        635      632       -3     
+ Partials      642      639       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@versile2 versile2 requested a review from ScarletKuro July 14, 2025 19:29
/// </summary>
/// <remarks>
/// Defaults to <c>true</c>. When <c>false</c>, the sort mode will only toggle between <see cref="SortDirection.Ascending"/> and <see cref="SortDirection.Descending"/>.
/// Defaults to <c>false</c>. When <c>false</c>, the sort mode will only toggle between <see cref="SortDirection.Ascending"/> and <see cref="SortDirection.Descending"/>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe switch the other part around to describe the new alternative:

When <c>false</c>, the sort mode will only toggle between <see cref="SortDirection.Ascending"/> and <see cref="SortDirection.Descending"/>.
When <c>true</c>....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, done

@sonarqubecloud
Copy link

@danielchalmers danielchalmers merged commit 4edc8ac into MudBlazor:dev Jul 15, 2025
6 checks passed
@versile2 versile2 deleted the fix_datagrid_11443 branch July 16, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended regression Previously worked and now doesn't

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants