MudTablePager: Fix InfoFormat ignoring custom text (#11466)#11468
Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom Jun 9, 2025
Merged
MudTablePager: Fix InfoFormat ignoring custom text (#11466)#11468ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro merged 1 commit intoMudBlazor:devfrom
Conversation
github-actions
bot
added
the
bug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11468 +/- ##
=======================================
Coverage 91.16% 91.16%
=======================================
Files 466 466
Lines 14452 14452
Branches 2799 2799
=======================================
Hits 13175 13175
Misses 641 641
Partials 636 636 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Anu6is
approved these changes
Jun 9, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the pager’s InfoFormat logic so that custom static text is respected (only empty formats fall back to the default), and adds unit tests to cover custom formatting.
- Changed
MudTablePagerto only use the default localized format whenInfoFormatis null or empty - Renamed the existing default-info test and introduced a new test (
TablePagerInfoTextTest2) for custom formats - Added a test component for verifying custom
InfoFormatexpressions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/MudBlazor/Components/Table/MudTablePager.razor.cs | Use string.IsNullOrEmpty to decide fallback and always return custom text otherwise |
| src/MudBlazor.UnitTests/Components/TableTests.cs | Renamed default pager info test and added TablePagerInfoTextTest2 for custom behavior |
| src/MudBlazor.UnitTests.Viewer/TestComponents/Table/TablePagerInfoTextTest2.razor | New test component to drive custom InfoFormat scenarios |
Comments suppressed due to low confidence (3)
src/MudBlazor.UnitTests/Components/TableTests.cs:2251
- [nitpick] The test method name
TablePagerInfoTextTest2is non‐descriptive; consider renaming it to something likeTablePagerInfoText_CustomFormatTestfor clarity.
public void TablePagerInfoTextTest2(string infoFormat, string expectedInfoText)
src/MudBlazor.UnitTests/Components/TableTests.cs:2248
- Consider adding a TestCase with a whitespace-only
InfoFormat(e.g." ") to verify it falls back to the default behavior if you switch toIsNullOrWhiteSpace.
[TestCase("", "1-3 of 3")]
src/MudBlazor.UnitTests/Components/TableTests.cs:2213
- The test references a component
TablePagerInfoTextTest1, but no corresponding Razor file was added or updated. Please confirm thatTablePagerInfoTextTest1.razorexists or update the reference.
public void TablePagerInfoTextTest1()
| var lastItem = Math.Min((Table?.CurrentPage + 1) * Table?.RowsPerPage ?? 0, filteredItemsCount); | ||
|
|
||
| if (InfoFormat.Contains("{first_item}") || InfoFormat.Contains("{last_item}") || InfoFormat.Contains("{all_items}")) | ||
| if (string.IsNullOrEmpty(InfoFormat)) |
There was a problem hiding this comment.
[nitpick] Consider using string.IsNullOrWhiteSpace(InfoFormat) to also treat whitespace-only formats as empty and correctly fall back to the default.
Suggested change
| if (string.IsNullOrEmpty(InfoFormat)) | |
| if (string.IsNullOrWhiteSpace(InfoFormat)) |
danielchalmers
approved these changes
Jun 9, 2025
ScarletKuro
approved these changes
Jun 9, 2025
This was referenced Aug 1, 2025
Closed
This was referenced Aug 14, 2025
This was referenced Aug 25, 2025
This was referenced Oct 6, 2025
This was referenced Nov 12, 2025
This was referenced Dec 12, 2025
Closed
Closed
This was referenced Dec 29, 2025
This was referenced Jan 9, 2026
Closed
This was referenced Feb 10, 2026
Closed
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InfoFormataccepts now custom strings that do not use parameters likefirst_item.Description
Fixes #11466.
How Has This Been Tested?
Created a new unit test for custom InfoFormats.
Type of Changes
Checklist
dev).