Improve accessibility labels and localize picker buttons#11456
Merged
danielchalmers merged 7 commits intoMudBlazor:devfrom Jun 6, 2025
Merged
Improve accessibility labels and localize picker buttons#11456danielchalmers merged 7 commits intoMudBlazor:devfrom
danielchalmers merged 7 commits intoMudBlazor:devfrom
Conversation
danielchalmers
added
accessibility
github-actions
bot
added
the
enhancement
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines accessibility and localization by converting ARIA/action labels to sentence case, adding dynamic show/hide swatch labels, and localizing picker adornment buttons.
- Standardizes resource strings to sentence case and trims lengthy ARIA labels
- Adds localized, state-dependent labels for color swatch toggling and tree-view expansion
- Replaces hard-coded picker aria labels with localized defaults
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/MudBlazor/Resources/LanguageResource.resx | Updated many resource values to sentence case; added new keys for show/hide swatches and open/expand actions |
| src/MudBlazor/Components/TreeView/MudTreeViewItemToggleButton.razor | Injected localizer and added dynamic aria-label based on expand/collapse state |
| src/MudBlazor/Components/TimePicker/MudTimePicker.razor.cs | Removed static AdornmentAriaLabel and set localized fallback in OnInitialized |
| src/MudBlazor/Components/DatePicker/MudDateRangePicker.razor.cs | Removed static AdornmentAriaLabel but no localized fallback added |
| src/MudBlazor/Components/DatePicker/MudBaseDatePicker.razor.cs | Added localized default for AdornmentAriaLabel in OnInitialized |
| src/MudBlazor/Components/ColorPicker/MudColorPicker.razor.cs | Localized AdornmentAriaLabel on init |
| src/MudBlazor/Components/ColorPicker/MudColorPicker.razor | Switched to dynamic, localized show/hide swatches aria-label |
Comments suppressed due to low confidence (4)
src/MudBlazor/Components/DatePicker/MudDateRangePicker.razor.cs:31
- The static
AdornmentAriaLabelwas removed but no localized fallback was added, leaving the button without an aria-label. Consider addingAdornmentAriaLabel ??= Localizer[LanguageResource.MudDateRangePicker_Open];inOnInitializedto maintain accessibility.
AdornmentAriaLabel = "Open Date Range Picker";
src/MudBlazor/Components/TreeView/MudTreeViewItemToggleButton.razor:15
- Remove the redundant '@' before
Localizerinside the razor expression. It should be@(Expanded ? Localizer[LanguageResource.MudTreeView_CollapseItem] : Localizer[LanguageResource.MudTreeView_ExpandItem])for valid syntax.
aria-label="@(Expanded ? @Localizer[LanguageResource.MudTreeView_CollapseItem] : @Localizer[LanguageResource.MudTreeView_ExpandItem])" />
src/MudBlazor/Components/TimePicker/MudTimePicker.razor.cs:550
Localizeris referenced here but not injected or defined in this code-behind. Add an[Inject] InternalMudLocalizer Localizer { get; set; }property (or similar) so that this reference compiles and runs correctly.
AdornmentAriaLabel ??= Localizer[LanguageResource.MudTimePicker_Open];
src/MudBlazor/Resources/LanguageResource.resx:262
- [nitpick] Replacing specific close labels like "Close Alert" or "Close Picker" with a generic "Close" reduces context for screen-reader users. Consider retaining element context (e.g., "Close alert") for clarity.
<value>Close</value>
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #11456 +/- ##
=======================================
Coverage 91.13% 91.13%
=======================================
Files 465 466 +1
Lines 14412 14417 +5
Branches 2790 2795 +5
=======================================
+ Hits 13134 13139 +5
Misses 641 641
Partials 637 637 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielchalmers
changed the title
meenzen
approved these changes
Jun 6, 2025
Contributor
meenzen
left a comment
meenzen
left a comment
There was a problem hiding this comment.
Localization looks correct, I will pull the LanguageResources changes into MudBlazor.Translations once this is merged.
versile2
added a commit
to versile2/MudBlazor
that referenced
this pull request
Jun 9, 2025
This was referenced Aug 1, 2025
This was referenced Oct 6, 2025
This was referenced Nov 12, 2025
This was referenced Dec 12, 2025
Closed
Closed
This was referenced Dec 29, 2025
This was referenced Jan 9, 2026
Closed
This was referenced Feb 10, 2026
Closed
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Type of Changes
Checklist
dev).