MudMenu: Hide popover overflow#11444
Conversation
github-actions
bot
added
the
bug
There was a problem hiding this comment.
Pull Request Overview
This PR narrows the overflow hiding behavior to menu popovers only by applying an overflow: hidden rule to .mud-popover elements that directly contain a .mud-menu-list, preventing hover effects from peeking through when the popover is rounded.
- Narrow overflow hiding to only affect menu popovers.
- Prevent unintended hover effects leaking from menu items.
Comments suppressed due to low confidence (1)
src/MudBlazor/Styles/components/_menu.scss:94
- [nitpick] Consider confirming that the use of the :has pseudo-class meets your browser support requirements, as it may not be supported in some older browser versions.
.mud-popover:has(> .mud-menu-list) {
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11444 +/- ##
=======================================
Coverage 91.13% 91.13%
=======================================
Files 465 466 +1
Lines 14412 14417 +5
Branches 2790 2792 +2
=======================================
+ Hits 13134 13139 +5
Misses 641 641
Partials 637 637 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
part of mudPopover.js actually set's a max height to allow popovers that extend beyond and can't flip the available space to have a scrollbar (set max-height), this would just clip it instead of allowing a scrollbar, is that the intent? |
I wasn't able to reproduce that, could you show me an example?
|
|
Actually no, I changed it to set the max-height on the popover itself not the list so this wouldn't affect that. It does check if the list has a max-height and I am under the impression that people are using overflow for scrollbars when max-height is set so this might affect them but my code doesn't I was mistaken. |
ScarletKuro
left a comment
ScarletKuro
left a comment
There was a problem hiding this comment.
Hope this doesn't cause problems like last time.
Description
Narrower version of #9993. Only affects the Menu (if it's a direct descendant for max compatibility against custom implementations) instead of all popovers indiscriminately. Does not apply to regular lists, only menu lists.
Snippet and images still apply.
How Has This Been Tested?
visually
Type of Changes
Checklist
dev).