Build: Remove "needs review" label from new PRs#11431
Build: Remove "needs review" label from new PRs#11431ScarletKuro merged 1 commit intoMudBlazor:devfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the automatic addition of the "PR: needs review" label on new pull requests to reduce visual noise.
- Eliminates the conditional block that applied the "PR: needs review" label for non-draft PRs
Comments suppressed due to low confidence (1)
.github/workflows/pr.yml:35
- Consider adding a workflow integration test or updating documentation to verify that new PRs no longer receive the "PR: needs review" label, since this behavior change isn't covered by existing tests.
if(!pr.draft) {
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11431 +/- ##
=======================================
Coverage 91.12% 91.13%
=======================================
Files 465 465
Lines 14412 14412
Branches 2790 2790
=======================================
+ Hits 13133 13134 +1
Misses 641 641
+ Partials 638 637 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I tend to agree seems superfluous and just another bit of admin. The GitHub reviewing process/approved status covers it I think. However @ScarletKuro may have reasons to keep it so I would defer the final decision. |
Description
I don't think it's serving a purpose beyond visual noise and is commonly not removed before merging anyway. Needing review is sort of implied.
How Has This Been Tested?
Type of Changes
Checklist
dev).