Skip to content

MudDataGrid: Groupable Logic#11383

Merged
ScarletKuro merged 9 commits intoMudBlazor:devfrom
versile2:fix/datagrid11349
Jun 9, 2025
Merged

MudDataGrid: Groupable Logic#11383
ScarletKuro merged 9 commits intoMudBlazor:devfrom
versile2:fix/datagrid11349

Conversation

@versile2
Copy link
Contributor

@versile2 versile2 commented May 21, 2025

Description

Resolves #11349 by separating DataGrid Groupable parameter from column groupable parameters to match previous behavior and fix a Breaking Change I accidentally introduced with Multi Level Grouping.
Updated Documentation for clarity:

image

How Has This Been Tested?

Made changes using TDD and have a working test at the end for both IsGrouping and what happens with Groupable is toggled. Visual testing in BSS and WASM as well.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels May 21, 2025
@versile2 versile2 marked this pull request as draft May 21, 2025 19:18
@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.15%. Comparing base (1c75e64) to head (326325e).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #11383   +/-   ##
=======================================
  Coverage   91.15%   91.15%           
=======================================
  Files         466      466           
  Lines       14452    14453    +1     
  Branches     2799     2800    +1     
=======================================
+ Hits        13174    13175    +1     
  Misses        641      641           
  Partials      637      637           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@versile2 versile2 marked this pull request as ready for review May 21, 2025 20:17
@versile2 versile2 requested a review from ScarletKuro May 21, 2025 20:17
@ScarletKuro
Copy link
Member

Seems like DataGrid_IsGrouping is faling, I only moved parameter little bit up, so either flaky or something else.

Copy link
Member

@ScarletKuro ScarletKuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, review the test.

@versile2
Copy link
Contributor Author

versile2 commented Jun 9, 2025

Please, review the test.

DC changed the aria text in language resources:
#11456

Updated to the new verbage. It was Show Column Options now it's Column options

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

V8.6.0 Grouping Broken

2 participants