Skip to content

MudDataGrid: Form Dialog Focus#11379

Merged
danielchalmers merged 1 commit intoMudBlazor:devfrom
versile2:enhance/datagrid11374
May 24, 2025
Merged

MudDataGrid: Form Dialog Focus#11379
danielchalmers merged 1 commit intoMudBlazor:devfrom
versile2:enhance/datagrid11374

Conversation

@versile2
Copy link
Contributor

@versile2 versile2 commented May 21, 2025

Description

Resolves part of #11374 by adding FirstChild to the default focus of the MudDialog when DataGrid uses EditMode.EditForm

How Has This Been Tested?

Visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels May 21, 2025
@versile2 versile2 requested a review from ScarletKuro May 21, 2025 14:04
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.11%. Comparing base (53ac2f9) to head (2c01793).
Report is 13 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #11379      +/-   ##
==========================================
- Coverage   91.11%   91.11%   -0.01%     
==========================================
  Files         465      465              
  Lines       14402    14401       -1     
  Branches     2785     2785              
==========================================
- Hits        13122    13121       -1     
  Misses        643      643              
  Partials      637      637

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@versile2
Copy link
Contributor Author

versile2 commented May 21, 2025

Also 2 questions. Not sure who would know.

  1. Why is the Mudglobal.DialogDefaults.DefaultFocus set to DefaultFocus.Element?
  2. What is DefaultFocus.Element for since it actually does nothing but focuses an empty div

@danielchalmers
Copy link
Member

danielchalmers commented May 21, 2025 •
edited
Loading

Also 2 questions. Not sure who would know.

  1. Why is the Mudglobal.DialogDefaults.DefaultFocus set to DefaultFocus.Element?
  2. What is DefaultFocus.Element for since it actually does nothing but focuses an empty div

I think the point of Element is to focus the dialog itself so you can start tabbing to elements inside if it, but I might be wrong. I'd like to look into changing it to FirstChild by default for v9

@versile2
Copy link
Contributor Author

versile2 commented May 21, 2025

Also 2 questions. Not sure who would know.

  1. Why is the Mudglobal.DialogDefaults.DefaultFocus set to DefaultFocus.Element?
  2. What is DefaultFocus.Element for since it actually does nothing but focuses an empty div

I think the point of Element is to focus the dialog itself so you can start tabbing to elements inside if it. I might be wrong. I'd like to look into changing it to FirstChild by default for v8

That makes total sense, I think the Docs or intellisense at least could use a nudge

@ScarletKuro ScarletKuro linked an issue May 21, 2025 that may be closed by this pull request
Submit form on Enter key in MudDataGrid edit dialog #11374
Open
2 tasks
@danielchalmers danielchalmers merged commit 86dd92f into MudBlazor:dev May 24, 2025
7 checks passed
@versile2 versile2 deleted the enhance/datagrid11374 branch July 16, 2025 15:46
This was referenced Jul 22, 2025
Closed
Closed
Closed
This was referenced Aug 1, 2025
Closed
Open
Open
Closed
Merged
Open
Closed
This was referenced Aug 14, 2025
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 25, 2025
Merged
Closed
This was referenced Oct 6, 2025
Open
Open
Open
@dependabot dependabot bot mentioned this pull request Oct 15, 2025
Closed
@dependabot dependabot bot mentioned this pull request Nov 3, 2025
Merged
This was referenced Nov 12, 2025
Closed
Closed
This was referenced Nov 25, 2025
Closed
Closed
Open
This was referenced Dec 12, 2025
Closed
Closed
Closed
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Dec 21, 2025
Closed
This was referenced Dec 29, 2025
Closed
Closed
This was referenced Jan 9, 2026
Closed
Closed
Closed
Merged
Closed
Closed
This was referenced Feb 10, 2026
Merged
Closed
Open
This was referenced Feb 23, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielchalmers danielchalmers danielchalmers approved these changes

@ScarletKuro ScarletKuro Awaiting requested review from ScarletKuro

Assignees

No one assigned

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Submit form on Enter key in MudDataGrid edit dialog

2 participants

@versile2 @danielchalmers