MudTablePager: Add thousands separator for all_items#11371
Merged
danielchalmers merged 1 commit intoMudBlazor:devfrom May 22, 2025
Merged
Conversation
github-actions
bot
added
enhancement
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11371 +/- ##
==========================================
- Coverage 91.11% 91.11% -0.01%
==========================================
Files 465 465
Lines 14402 14402
Branches 2785 2785
==========================================
- Hits 13123 13122 -1
Misses 643 643
- Partials 636 637 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a thousands separator for the "all_items" value in MudTablePager to improve number readability.
- Updated the string interpolation for the all_items value in the Info property.
- Adjusted the Localizer call to use the formatted number with a thousands separator.
Comments suppressed due to low confidence (1)
src/MudBlazor/Components/Table/MudTablePager.razor.cs:125
- The thousands separator implementation appears correct, but it's only visually tested. Consider adding unit tests to verify the formatting behavior across different culture settings.
.Replace("{all_items}", $"{filteredItemsCount:N0}");
danielchalmers
approved these changes
May 20, 2025
Member
danielchalmers
left a comment
danielchalmers
left a comment
There was a problem hiding this comment.
LGTM. An invariant test might help
versile2
approved these changes
May 21, 2025
This was referenced Aug 1, 2025
Closed
This was referenced Aug 14, 2025
This was referenced Aug 25, 2025
This was referenced Oct 6, 2025
This was referenced Nov 12, 2025
This was referenced Dec 12, 2025
Closed
Closed
This was referenced Dec 29, 2025
This was referenced Jan 9, 2026
Closed
This was referenced Feb 10, 2026
Closed
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added thousands separator for all_items of MudTablePager
How Has This Been Tested?
It has only been tested visually.
Type of Changes
Example
Note: the string interpolation
$"{filteredItemsCount:N0}"usesCultureInfo.CurrentCultureby default.In this environment, the culture is set to
it-IT(Italian), so the thousands separator is a dot (.).For example, 88088 will be formatted as 88.088.
The output may vary depending on the culture settings of the environment where the application is running.
Before
After
Checklist
dev).