Skip to content

MudInput: Fix Disposal of IOS Blur#11347

Merged
ScarletKuro merged 3 commits intoMudBlazor:devfrom
versile2:fix/11322inputdispose
May 17, 2025
Merged

MudInput: Fix Disposal of IOS Blur#11347
ScarletKuro merged 3 commits intoMudBlazor:devfrom
versile2:fix/11322inputdispose

Conversation

@versile2
Copy link
Contributor

@versile2 versile2 commented May 16, 2025

Description

Resolves #11322
by removing the animationFrame check and adding a catch check on the invoke.
Also changed the disposal to be from the extension instead of run manually.

How Has This Been Tested?

I created a test component following the example and run in Docs.Server. I confirmed without changes the example threw an error, and with changes it did not. I deleted the example after but if you look at my branch one commit before the "remove" you can see or copy the example.

I tested all TextField Doc.Server and UnitTests.Viewer cases.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels May 16, 2025
@sonarqubecloud
Copy link

@ScarletKuro
Copy link
Member

Resolves #113322

could you fix this, there is no such issue.

@versile2
Copy link
Contributor Author

versile2 commented May 17, 2025 via email

@ScarletKuro
Copy link
Member

11347

Thats your PR number.

@versile2
Copy link
Contributor Author

Sorry was looking for my branch 11322 since I named it after it lol

@ScarletKuro ScarletKuro changed the title MudInput - Fix Disposal of IOS Blur MudInput: Fix Disposal of IOS Blur May 17, 2025
@ScarletKuro ScarletKuro merged commit 7eeef66 into MudBlazor:dev May 17, 2025
7 checks passed
@ScarletKuro ScarletKuro deleted the fix/11322inputdispose branch May 17, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudTextField casues dialog to crash in v8.6.0 -> MudInput: Dispose DotNetObjectReference

2 participants