Skip to content

PopoverProvider: Multiple Layouts#11305

Merged
ScarletKuro merged 7 commits intoMudBlazor:devfrom
versile2:fix/popovertwocontainers
May 16, 2025
Merged

PopoverProvider: Multiple Layouts#11305
ScarletKuro merged 7 commits intoMudBlazor:devfrom
versile2:fix/popovertwocontainers

Conversation

@versile2
Copy link
Contributor

@versile2 versile2 commented May 7, 2025 •
edited
Loading

Description

Resolves #11293 to ensure when MudPopoverProvider is not the original it still observes properly.
Resolves #11326

How Has This Been Tested?

Visual Tests and setup a complex testing method in the Viewer for PopoverTwoLayoutsTest.razor since this has come up in other PRs, this will give us a way to test.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@versile2 versile2 requested a review from ScarletKuro May 7, 2025 20:19
@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels May 7, 2025
@codecov
Copy link

codecov bot commented May 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (2468042) to head (d96cacc).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev   #11305   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files         465      465           
  Lines       14400    14400           
  Branches     2787     2787           
=======================================
  Hits        13122    13122           
  Misses        642      642           
  Partials      636      636

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ScarletKuro
Copy link
Member

ScarletKuro commented May 7, 2025

Please, check your indents

@versile2
Copy link
Contributor Author

versile2 commented May 7, 2025

Please, check your indents

Whoops. Every time I use paste it screws it up but most of the time hitting the Beautify fixes it, I did not this time. Let me know if I missed any more.

ScarletKuro
ScarletKuro reviewed May 16, 2025
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ScarletKuro ScarletKuro changed the title PopoverProvider - Multiple Layouts PopoverProvider: Multiple Layouts May 16, 2025
@ScarletKuro ScarletKuro merged commit 34a2365 into MudBlazor:dev May 16, 2025
6 checks passed
@ScarletKuro ScarletKuro deleted the fix/popovertwocontainers branch May 16, 2025 14:13
@Hastaroth1
Copy link

Hastaroth1 commented May 20, 2025

Hello. Is there a general idea of when you expect this to be released?

@versile2
Copy link
Contributor Author

versile2 commented May 20, 2025

Hello. Is there a general idea of when you expect this to be released?

It varies and I'm not the one that decides that but usually about a month apart for releases. Last release was April 29.

@ScarletKuro ScarletKuro mentioned this pull request May 25, 2025
Closed
4 tasks
This was referenced Jul 22, 2025
Closed
Closed
Closed
This was referenced Aug 1, 2025
Closed
Open
Open
Closed
This was referenced Oct 6, 2025
Open
Open
Open
@dependabot dependabot bot mentioned this pull request Oct 15, 2025
Closed
@dependabot dependabot bot mentioned this pull request Nov 3, 2025
Merged
This was referenced Nov 12, 2025
Closed
Closed
This was referenced Nov 25, 2025
Closed
Closed
Open
This was referenced Dec 12, 2025
Closed
Closed
Closed
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Dec 21, 2025
Closed
This was referenced Dec 29, 2025
Closed
Closed
This was referenced Jan 9, 2026
Closed
Closed
Closed
Merged
Closed
Closed
This was referenced Feb 10, 2026
Merged
Closed
Open
This was referenced Feb 23, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScarletKuro ScarletKuro ScarletKuro approved these changes

Assignees

No one assigned

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dropdowns / Menus Not Appearing After Route Update MudMenu intermittently fails to display menu items in WASM app (regression in v8.6.0)

3 participants

@versile2 @ScarletKuro @Hastaroth1