Skip to content

MudInput - Heap Locked When Disabled#11135

Merged
ScarletKuro merged 3 commits intoMudBlazor:devfrom
versile2:fix/inputheapblur
Apr 2, 2025
Merged

MudInput - Heap Locked When Disabled#11135
ScarletKuro merged 3 commits intoMudBlazor:devfrom
versile2:fix/inputheapblur

Conversation

@versile2
Copy link
Contributor

@versile2 versile2 commented Apr 2, 2025

Description

Events in javascript depend on the element being drawn, in some refreshes/redraws the manual blur event is attempting to fire during a redraw (or heap lock). Simply waiting until the Dom is done fixes the issue.

How Has This Been Tested?

Visual Testing, minimal changes

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

- Modified `mudElementReference.js` to invoke `dotNetReference` after heap unlock using `requestAnimationFrame`.
- Added a new `MudTextField` component in `InputHeapLockedTest.razor` with attributes for user input.

- V2
@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Apr 2, 2025
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.00%. Comparing base (11a8013) to head (8698b99).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #11135   +/-   ##
=======================================
  Coverage   90.99%   91.00%           
=======================================
  Files         431      436    +5     
  Lines       14055    14095   +40     
  Branches     2722     2726    +4     
=======================================
+ Hits        12790    12827   +37     
- Misses        650      651    +1     
- Partials      615      617    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@versile2 versile2 requested a review from ScarletKuro April 2, 2025 18:18
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2025

@ScarletKuro ScarletKuro merged commit df259cb into MudBlazor:dev Apr 2, 2025
4 checks passed
@versile2 versile2 deleted the fix/inputheapblur branch April 9, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudTextField throws 'heap is currently locked' error during onKeyDown events

2 participants