Skip to content

MudDateRangePicker: Re-enable selecting end date before start date (fix regression)#11126

Merged
ScarletKuro merged 2 commits intoMudBlazor:devfrom
Anu6is:11121-MudDateRangePicker-SelectStartBeforeEnd
Apr 1, 2025
Merged

MudDateRangePicker: Re-enable selecting end date before start date (fix regression)#11126
ScarletKuro merged 2 commits intoMudBlazor:devfrom
Anu6is:11121-MudDateRangePicker-SelectStartBeforeEnd

Conversation

@Anu6is
Copy link
Contributor

@Anu6is Anu6is commented Apr 1, 2025

Description

The introduction of Min/Max days constraint inadvertently prevented selecting an end date before a start date when Min/Max days is not being used. This change corrects this regression.

Fixes #11121

How Has This Been Tested?

  • corrected unit test
  • tested visually
  • re-ran unit tests

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Apr 1, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2025

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.98%. Comparing base (11a8013) to head (6555f3f).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
.../Components/DatePicker/MudDateRangePicker.razor.cs 0.00% 0 Missing and 2 partials ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #11126      +/-   ##
==========================================
- Coverage   90.99%   90.98%   -0.02%     
==========================================
  Files         431      431              
  Lines       14055    14055              
  Branches     2722     2724       +2     
==========================================
- Hits        12790    12788       -2     
  Misses        650      650              
- Partials      615      617       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ScarletKuro ScarletKuro merged commit ef34a47 into MudBlazor:dev Apr 1, 2025
6 of 7 checks passed
@Anu6is Anu6is deleted the 11121-MudDateRangePicker-SelectStartBeforeEnd branch April 3, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Original functionality from PR #10680 lost after merging PR #10769

2 participants