MudTreeViewItem: Fix NullReferenceException#11108
Merged
ScarletKuro merged 5 commits intoMudBlazor:devfrom Mar 30, 2025
Merged
Conversation
The debug asserts are asserting a case that's not necessarily true. If the type `T` of the parent node is not the same as the type `T` of the current node, `this.MudTreeRoot` will be null.
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11108 +/- ##
=======================================
Coverage 90.97% 90.97%
=======================================
Files 431 431
Lines 14047 14051 +4
Branches 2726 2727 +1
=======================================
+ Hits 12779 12783 +4
Misses 651 651
Partials 617 617 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ScarletKuro
changed the title
|
This was referenced Aug 1, 2025
This was referenced Aug 18, 2025
This was referenced Sep 8, 2025
This was referenced Oct 5, 2025
This was referenced Jan 3, 2026
This was referenced Jan 11, 2026
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a
MudTreeViewItemhas aValuewhose type that does not match the tree's typeT, this compiles just fine, (and is quite necessary in many use cases,) but clicking on the node causes a crash, as detailed in the bug report.Resolves #11093.
How Has This Been Tested?
Added a unit test that demonstrates this crash, and does not crash with the fix in place.
Type of Changes
Checklist
dev).