ObserverManager: Optimize to reduce dictionary lookups#11067
Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom Mar 20, 2025
Merged
ObserverManager: Optimize to reduce dictionary lookups#11067ScarletKuro merged 1 commit intoMudBlazor:devfrom
ScarletKuro merged 1 commit intoMudBlazor:devfrom
Conversation
github-actions
bot
added
bug
ScarletKuro
added
the
performance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11067 +/- ##
=======================================
Coverage 91.05% 91.05%
=======================================
Files 429 429
Lines 13956 13964 +8
Branches 2698 2698
=======================================
+ Hits 12707 12715 +8
Misses 646 646
Partials 603 603 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This was referenced Aug 1, 2025
This was referenced Aug 18, 2025
This was referenced Sep 8, 2025
This was referenced Oct 5, 2025
This was referenced Dec 29, 2025
This was referenced Jan 9, 2026
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds new
TryGetOrAddSubscriptionmethod to avoid usingIsSubscribed+Subscribepattern which results in additional lookups.How Has This Been Tested?
New unit tests, existing ones on the
BrowserViewportServiceandKeyInterceptorService.Type of Changes
Checklist
dev).