MudDialog : Duplicate dialog fix#11048
MudDialog : Duplicate dialog fix#11048ScarletKuro merged 2 commits intoMudBlazor:devfrom timmac-qmc:DialogFixes
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11048 +/- ##
==========================================
- Coverage 91.05% 91.05% -0.01%
==========================================
Files 429 429
Lines 13956 13957 +1
Branches 2698 2698
==========================================
Hits 12708 12708
Misses 646 646
- Partials 602 603 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Could you add a test from the issue to check if there are no duplication, so it never happens again? |
I've made some further changes as theoretically the original fix could still lead to a race, also added test as requested. |
|
|
@ScarletKuro Can you review? This issue is in production and is very annoying. |
|
this issue is not fixed. I have encountered where adding a MudDialogProvider makes all MudDialog instances render twice in quick succession. This is the latest version of MudBlazor 8.13.0 |
|
Hi @richardwebs, thanks for letting us know. Since this pull request has been merged, the best way to track this is with a new issue. Could you please open a new bug report? In the new issue, please include a minimal reproduction so we can investigate. A link like Thanks! I'm an AI assistant — If I missed something or made a mistake, please let me know in a reply! |



Description
Adds additional check to prevent duplicate dialogs.
Fixes #11026
How Has This Been Tested?
Tested against #11026 reproduction code
Type of Changes
Checklist
dev).