Skip to content

MudDialog : Duplicate dialog fix#11048

Merged
ScarletKuro merged 2 commits intoMudBlazor:devfrom
timmac-qmc:DialogFixes
Mar 21, 2025
Merged

MudDialog : Duplicate dialog fix#11048
ScarletKuro merged 2 commits intoMudBlazor:devfrom
timmac-qmc:DialogFixes

Conversation

@timmac-qmc
Copy link
Contributor

@timmac-qmc timmac-qmc commented Mar 18, 2025

Description

Adds additional check to prevent duplicate dialogs.
Fixes #11026

How Has This Been Tested?

Tested against #11026 reproduction code

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Mar 18, 2025
@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.05%. Comparing base (7a1d720) to head (139949c).
Report is 5 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #11048      +/-   ##
==========================================
- Coverage   91.05%   91.05%   -0.01%     
==========================================
  Files         429      429              
  Lines       13956    13957       +1     
  Branches     2698     2698              
==========================================
  Hits        12708    12708              
  Misses        646      646              
- Partials      602      603       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ScarletKuro
Copy link
Member

Could you add a test from the issue to check if there are no duplication, so it never happens again?
Rest looks good.

@timmac-qmc
Copy link
Contributor Author

Could you add a test from the issue to check if there are no duplication, so it never happens again? Rest looks good.

I've made some further changes as theoretically the original fix could still lead to a race, also added test as requested.

@sonarqubecloud
Copy link

@timmac-qmc
Copy link
Contributor Author

@ScarletKuro Can you review? This issue is in production and is very annoying.

@ScarletKuro ScarletKuro changed the title Additional duplicate dialog fixes MudDialog : Duplicate dialog fix Mar 21, 2025
@ScarletKuro ScarletKuro merged commit 68a2118 into MudBlazor:dev Mar 21, 2025
6 checks passed
@timmac-qmc timmac-qmc deleted the DialogFixes branch March 25, 2025 09:51
@timmac-qmc timmac-qmc mentioned this pull request Apr 9, 2025
4 tasks
@richardwebs
Copy link

richardwebs commented Oct 22, 2025

this issue is not fixed. I have encountered where adding a MudDialogProvider makes all MudDialog instances render twice in quick succession. This is the latest version of MudBlazor 8.13.0

@mudbot
Copy link

mudbot bot commented Oct 22, 2025

Hi @richardwebs, thanks for letting us know.

Since this pull request has been merged, the best way to track this is with a new issue. Could you please open a new bug report?

In the new issue, please include a minimal reproduction so we can investigate. A link like https://try.mudblazor.com/snippet/XXXX or a minimal repo is ideal for confirming and debugging the problem. You can also link back to this PR for context.

Thanks!


I'm an AI assistant — If I missed something or made a mistake, please let me know in a reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudDialog: Duplicate dialogs v8

3 participants