MudSelect: Fix menu toggled on non-primary mouse clicks #11002
Merged
henon merged 3 commits intoMudBlazor:devfrom Mar 13, 2025
Merged
MudSelect: Fix menu toggled on non-primary mouse clicks #11002henon merged 3 commits intoMudBlazor:devfrom
henon merged 3 commits intoMudBlazor:devfrom
Conversation
github-actions
bot
added
breaking change
versile2
removed
breaking change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11002 +/- ##
=======================================
Coverage 91.01% 91.01%
=======================================
Files 429 429
Lines 13943 13946 +3
Branches 2695 2696 +1
=======================================
+ Hits 12690 12693 +3
Misses 648 648
Partials 605 605 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
danielchalmers
approved these changes
Mar 12, 2025
Contributor
|
Update title |
Contributor
Author
|
I'm horribly at Titles and naming in general but this is the greatest Title I've come up with yet (until it's renamed properly) |
danielchalmers
changed the title
Member
|
Was this tested on touch devices? |
Contributor
Author
No, didn't think about it. I will test it tonight. Good catch. |
Contributor
Author
Can confirm works on Android and IOS and according to the web onmousedown treats touch as left click. |
ScarletKuro
approved these changes
Mar 13, 2025
Contributor
|
Thanks @versile2 |
2 tasks
This was referenced Aug 18, 2025
This was referenced Sep 8, 2025
This was referenced Oct 5, 2025
This was referenced Dec 29, 2025
This was referenced Jan 9, 2026
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Separate mousedown event from ToggleMenu and wire it to only fire when left click is used.
Resolves #10984
How Has This Been Tested?
Visually and Added a unit test
Type of Changes
Checklist
dev).