Skip to content

MudChart/Heatmap: Add Min/Max Overrides#10985

Merged
ScarletKuro merged 6 commits intoMudBlazor:devfrom
versile2:enhance/heatmapminmax
Mar 9, 2025
Merged

MudChart/Heatmap: Add Min/Max Overrides#10985
ScarletKuro merged 6 commits intoMudBlazor:devfrom
versile2:enhance/heatmapminmax

Conversation

@versile2
Copy link
Contributor

@versile2 versile2 commented Mar 9, 2025

Description

Resolves #10981
Found/Fixed some bugginess with min/max value setting as well
Added additional Doc section

Screenshot 2025-03-09 005343
Screenshot 2025-03-09 005353
Screenshot 2025-03-09 005405

How Has This Been Tested?

Visually, added unit test covering changes

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@versile2 versile2 requested a review from henon March 9, 2025 07:04
@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended docs Updates/improvements to project documentation that do not affect core library logic enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Mar 9, 2025
@codecov
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.00%. Comparing base (d69cbf1) to head (acd238b).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10985      +/-   ##
==========================================
+ Coverage   90.99%   91.00%   +0.01%     
==========================================
  Files         429      429              
  Lines       13934    13939       +5     
  Branches     2693     2697       +4     
==========================================
+ Hits        12679    12685       +6     
- Misses        649      650       +1     
+ Partials      606      604       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@henon henon removed docs Updates/improvements to project documentation that do not affect core library logic enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library labels Mar 9, 2025
Copy link
Contributor

@henon henon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@henon henon changed the title Enhance Heatmap - Add Min/Max Overrides MudChart/Heatmap: Add Min/Max Overrides Mar 9, 2025
@henon
Copy link
Contributor

henon commented Mar 9, 2025

The only thing I am not 100% sure is the location of the Min/Max parameters. On the cell seems not optimal. Is there no other central place where you could add them?

@versile2
Copy link
Contributor Author

versile2 commented Mar 9, 2025

To be honest I really thought about adding a HeatMapSettings component to carry all the heatmap individual settings but decided that would be another PR, likely for V9 since it's a big breaking change. That being said the only other option was to add to ChartOptions which is yet another HeatMap only setting in Chart Options. No good solutions in my opinion.

Copy link
Member

@ScarletKuro ScarletKuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just few nits

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudChart HeatMap Min and Max value

3 participants