MudChart/Heatmap: Add Min/Max Overrides#10985
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10985 +/- ##
==========================================
+ Coverage 90.99% 91.00% +0.01%
==========================================
Files 429 429
Lines 13934 13939 +5
Branches 2693 2697 +4
==========================================
+ Hits 12679 12685 +6
- Misses 649 650 +1
+ Partials 606 604 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The only thing I am not 100% sure is the location of the Min/Max parameters. On the cell seems not optimal. Is there no other central place where you could add them? |
|
To be honest I really thought about adding a HeatMapSettings component to carry all the heatmap individual settings but decided that would be another PR, likely for V9 since it's a big breaking change. That being said the only other option was to add to ChartOptions which is yet another HeatMap only setting in Chart Options. No good solutions in my opinion. |
src/MudBlazor.Docs/Pages/Components/Charts/Examples/HeatMapExample7.razor
Outdated
Show resolved
Hide resolved
src/MudBlazor.Docs/Pages/Components/Charts/Examples/HeatMapExample7.razor
Outdated
Show resolved
Hide resolved
src/MudBlazor.Docs/Pages/Components/Charts/Examples/HeatMapExample7.razor
Outdated
Show resolved
Hide resolved
|



Description
Resolves #10981
Found/Fixed some bugginess with min/max value setting as well
Added additional Doc section
How Has This Been Tested?
Visually, added unit test covering changes
Type of Changes
Checklist
dev).