Conversation
github-actions
bot
added
bug
| /// Can be overridden by <see cref="MudGlobal.Rounded"/> | ||
| /// When <c>true</c>, the <c>border-radius</c> CSS style is set to <c>0</c>. | ||
| /// </remarks> | ||
| [Parameter] | ||
| [Category(CategoryTypes.AvatarGroup.Appearance)] | ||
| public bool MaxSquare { get; set; } | ||
| public bool MaxSquare { get; set; } = MudGlobal.Rounded == false; | ||
|
|
||
| /// <summary> | ||
| /// Shows rounded corners when the number of avatars exceeds <see cref="Max"/>. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// Defaults to <c>false</c>. When <c>true</c>, the <c>border-radius</c> style is set to the theme's default value. | ||
| /// Defaults to <c>false</c>. | ||
| /// Can be overridden by <see cref="MudGlobal.Rounded"/> | ||
| /// When <c>true</c>, the <c>border-radius</c> style is set to the theme's default value. | ||
| /// </remarks> | ||
| [Parameter] | ||
| [Category(CategoryTypes.AvatarGroup.Appearance)] | ||
| public bool MaxRounded { get; set; } | ||
| public bool MaxRounded { get; set; } = MudGlobal.Rounded == true; | ||
|
|
There was a problem hiding this comment.
Are we 100% sure of this automatism?
There was a problem hiding this comment.
It seemed to me that this uses the same concepts as other places; explicit squared styling when MudGlobal.Rounded is explicitly equal to false. I do not see why this one would be different?
Anu6is
left a comment
Anu6is
left a comment
There was a problem hiding this comment.
I'm ok with the changes in general except for MaxSquare.
Do you have a particular reason for that change?
| [Parameter] | ||
| [Category(CategoryTypes.AvatarGroup.Appearance)] | ||
| public bool MaxSquare { get; set; } | ||
| public bool MaxSquare { get; set; } = MudGlobal.Rounded == false; |
There was a problem hiding this comment.
I'm not sure this change is necessary
There was a problem hiding this comment.
It seemed to me that this uses the same concepts as other places; explicit squared styling when MudGlobal.Rounded is explicitly equal to false. I do not see why this one would be different?
There was a problem hiding this comment.
Ok, I think my initial concern was it changes the default behavior, but since the global values is nullable, this should still result in the default being false.
|
The failing test seems unrelated: I wonder why the dates seem to be not the same and which PR messed this up. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10957 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 427 427
Lines 13581 13585 +4
Branches 2603 2603
=======================================
+ Hits 12480 12484 +4
Misses 526 526
Partials 575 575 ☔ View full report in Codecov by Sentry. |
|
Thanks @Devqon |
3 participants
Description
Some components do not make use of the
MudGlobal.Roundedproperty properly.This is a follow-up for #10944 that was only targeted at the
MudProgressLinear.Added consistency for components:
MudAvatar(+MudAvatarGroup)MudNavMenu(documentation only)MudProgressCircularMudProgressLinear(documentation only)MudTabs(documentation only)How Has This Been Tested?
MudGlobal.RoundedtotrueType of Changes
Checklist
dev).- [ ] I've added relevant tests.