Skip to content

MudProgressLinear: Use MudGlobal.Rounded as default.#10944

Merged
henon merged 1 commit intoMudBlazor:devfrom
Devqon:fix/progress-linear-rounded-settings
Mar 3, 2025
Merged

MudProgressLinear: Use MudGlobal.Rounded as default.#10944
henon merged 1 commit intoMudBlazor:devfrom
Devqon:fix/progress-linear-rounded-settings

Conversation

@Devqon
Copy link
Contributor

@Devqon Devqon commented Feb 27, 2025

Description

The Rounded property of the MudProgressLinear should use the MudGlobal.Rounded property. The documentation already says it does, but it was not actually included in the implementation.

How Has This Been Tested?

  • Tested manually using the MudBlazor.Docs.Server by doing this in Program.cs:
var builder = WebApplication.CreateBuilder(args);

MudGlobal.Rounded = true;

// Add services to the container.
builder.Services.AddControllersWithViews();
builder.Services.AddRazorPages();
builder.Services.AddServerSideBlazor();
builder.Services.AddHttpClient<GitHubApiClient>();
builder.Services.TryAddDocsViewServices();
builder.Services.AddHttpContextAccessor();
  • No unittest added; It uses a static property and I found out that there aren't any unittests for the properties that are used there. I assume this is to prevent clashing unittests which make use of the same static properties which might cause race conditions in parallel unittests.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
    - [ ] I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Feb 27, 2025
@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (44cf632) to head (6418c83).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10944   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         427      427           
  Lines       13580    13581    +1     
  Branches     2603     2603           
=======================================
+ Hits        12479    12480    +1     
  Misses        526      526           
  Partials      575      575           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Devqon Devqon closed this Mar 2, 2025
@Devqon Devqon reopened this Mar 2, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2025

@henon henon changed the title MudProgressLinear: Fix usage of MudGlobal.Rounded MudProgressLinear: Use MudGlobal.Rounded as default. Mar 3, 2025
@henon henon merged commit b21e444 into MudBlazor:dev Mar 3, 2025
10 of 11 checks passed
@henon
Copy link
Contributor

henon commented Mar 3, 2025

Thanks

@Devqon Devqon deleted the fix/progress-linear-rounded-settings branch March 3, 2025 10:00
@Anu6is
Copy link
Contributor

Anu6is commented Mar 3, 2025

@henon should this be applied to the circular variant as well?

@Devqon
Copy link
Contributor Author

Devqon commented Mar 3, 2025

@henon should this be applied to the circular variant as well?

Yeah that makes sense, I failed to see that it was an option on that component as well.

@henon
Copy link
Contributor

henon commented Mar 3, 2025

@Devqon you can open a new PR and tag me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants