Prevent Rendering of unused MudPopover and MudOverlay#10853
Prevent Rendering of unused MudPopover and MudOverlay#10853henon merged 7 commits intoMudBlazor:devfrom
Conversation
github-actions
bot
added
the
bug
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (83.33%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #10853 +/- ##
==========================================
- Coverage 91.91% 91.89% -0.02%
==========================================
Files 427 427
Lines 13570 13580 +10
Branches 2599 2604 +5
==========================================
+ Hits 12473 12480 +7
- Misses 524 525 +1
- Partials 573 575 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@versile2 Can I help somehow to fix the formatting? |
no sorry missed this one, fixing now. |
|
pretty sure I got them all even bad formatting that I didn't change at least in those files! Let me know if I missed something. |
|
@ScarletKuro Could you please check this PR if you have time? We are really waiting for this enhancement and hopefully it will be released in v8.3.0 . |
|
|
Does this PR need anything else? |
|
henon or dc have yet to take a look at it as they've both been swamped. Assuming it passes muster it will definitely be in 8.4 just have to let them get caught up. |
| @if (PickerVariant == PickerVariant.Inline) | ||
| { | ||
| <MudPopover Class="@PopoverClassname" Open="@Open" Fixed="true" AnchorOrigin="@(AnchorOrigin)" TransformOrigin="@(TransformOrigin)" OverflowBehavior="@(OverflowBehavior)" RelativeWidth="@(RelativeWidth)" Paper="false"> | ||
| <div @ref="_pickerInlineRef" class="@PickerInlineClassname"> | ||
| <MudPaper @attributes="UserAttributes" Class="@PickerPaperClassname" Style="@PickerPaperStylename" Square="@_pickerSquare"> | ||
| <div class="@PickerContainerClassname"> | ||
| @if (PickerContent != null) | ||
| { | ||
| @PickerContent | ||
| } | ||
| </div> | ||
| @if (PickerActions != null) | ||
| { | ||
| @PickerContent | ||
| <div class="@ActionsClassname"> | ||
| @PickerActions(this) | ||
| </div> | ||
| } | ||
| </div> | ||
| @if (PickerActions != null) | ||
| { | ||
| <div class="@ActionsClassname"> | ||
| @PickerActions(this) | ||
| </div> | ||
| } | ||
| </MudPaper> | ||
| </div> | ||
| </MudPopover> | ||
| } | ||
| </MudPaper> | ||
| </div> | ||
| </MudPopover> | ||
| } |
There was a problem hiding this comment.
Is the indentation correct here? It looks like there are too many spaces
There was a problem hiding this comment.
I can't find any problems with it.
henon
left a comment
henon
left a comment
There was a problem hiding this comment.
Make sure the razor indentation is correct. It can be merged then.
|
Thanks @versile2 |
4 participants
Description
This PR puts if statements around rendering of certain MudPopover items; Tooltip, MudMenu, and ColumnOptions to improve performance.
Resolved #10815
Resolves #10689
How Has This Been Tested?
Visually tested each component in Viewer and Docs
Unit Tests updated
Type of Changes
Checklist
dev).