MudTooltip: Remove width:fit-content#10720
Conversation
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10720 +/- ##
=======================================
Coverage 91.83% 91.83%
=======================================
Files 427 427
Lines 13425 13425
Branches 2589 2589
=======================================
Hits 12329 12329
Misses 523 523
Partials 573 573 ☔ View full report in Codecov by Sentry. |
|
|
We should avoid new properties and make it work out of the box if possible (FullWidth) FYI it was added in #3030. Any ideas why @Garderoben ? |
I don't think that's possible. there may be varying scenarios that come into play at it would be difficult to assume if the user want full width or not. |
danielchalmers
left a comment
danielchalmers
left a comment
There was a problem hiding this comment.
@Garderoben isn't sure of the original reason it was included so we agree on changing it then seeing if any regressions are found later
|
Maybe we take some inspiration from MD3, plain vs rich tooltips: https://m3.material.io/components/tooltips/overview |
3 participants
Description
Setting
width: fit-contentonmud-tooltip-rootprevented theInlinetoggle from working as expected.This removes the unnecessary width definition. I've added visual test cases for all the reported odd tooltip wrapping behavior that I could find. With
fit-contentremoved, most can be solved by settingInline="false"while a few resolved naturally with just the removal offit-content. There were two cases whereRootClass="mud-width-full"was required (i.e. wrapping the Tooltip in aMudStackor aMudTd)Question:
Should we add a
FullWidthoption to theMudTooltipto facilitate the cases whereRootClass="mud-width-full"may be needed?How Has This Been Tested?
Visually - Test view and Docs
Fixes: #1167
Fixes: #3844 (closed incorrectly)
Type of Changes
Checklist
dev).