Skip to content

MudAutocomplete: Restore ScrollToListItemAsync API method#10717

Merged
ScarletKuro merged 2 commits intoMudBlazor:devfrom
danielchalmers:autocomplete-restore-scroll-api
Jan 26, 2025
Merged

MudAutocomplete: Restore ScrollToListItemAsync API method#10717
ScarletKuro merged 2 commits intoMudBlazor:devfrom
danielchalmers:autocomplete-restore-scroll-api

Conversation

@danielchalmers
Copy link
Member

@danielchalmers danielchalmers commented Jan 26, 2025 •
edited
Loading

Description

Adds back an API that was unnecessarily removed in #10161.

#10161 (comment)

How Has This Been Tested?

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Jan 26, 2025
@danielchalmers danielchalmers mentioned this pull request Jan 26, 2025
Merged
7 tasks
@danielchalmers danielchalmers requested a review from henon January 26, 2025 18:01
@codecov
Copy link

codecov bot commented Jan 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (febf779) to head (5f95ba7).
Report is 2 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev   #10717   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files         427      427           
  Lines       13424    13425    +1     
  Branches     2589     2589           
=======================================
+ Hits        12328    12329    +1     
  Misses        523      523           
  Partials      573      573

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro
Copy link
Member

ScarletKuro commented Jan 26, 2025

Can we also return back the xml comment?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ScarletKuro ScarletKuro merged commit 6962133 into MudBlazor:dev Jan 26, 2025
6 checks passed
@seedysoft seedysoft mentioned this pull request Jan 27, 2025
Merged
@dependabot dependabot bot mentioned this pull request Aug 1, 2025
Closed
This was referenced Aug 18, 2025
Closed
Merged
@dependabot dependabot bot mentioned this pull request Aug 27, 2025
Merged
@dependabot dependabot bot mentioned this pull request Sep 8, 2025
Closed
@dependabot dependabot bot mentioned this pull request Sep 22, 2025
Closed
This was referenced Oct 5, 2025
Merged
Open
Open
@dependabot dependabot bot mentioned this pull request Nov 3, 2025
Merged
@dependabot dependabot bot mentioned this pull request Nov 12, 2025
Closed
@dependabot dependabot bot mentioned this pull request Dec 21, 2025
Closed
This was referenced Dec 29, 2025
Closed
Closed
This was referenced Jan 9, 2026
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Jan 12, 2026
Merged
This was referenced Feb 23, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henon henon henon approved these changes

Assignees

No one assigned

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielchalmers @ScarletKuro @henon