MudTable: Show the default cursor for sortable headers when sorting is disabled#10703
Conversation
github-actions
bot
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10703 +/- ##
==========================================
+ Coverage 91.83% 91.85% +0.02%
==========================================
Files 427 427
Lines 13425 13436 +11
Branches 2589 2594 +5
==========================================
+ Hits 12329 12342 +13
Misses 523 523
+ Partials 573 571 -2 ☔ View full report in Codecov by Sentry. |
|
Is the test page empty?
|
|
My initial goal was to create the simplest possible test component.
|
|
Although I'm not sure why the tests started failing, it doesn't appear to be related to my changes. |
|
Thanks, I'll check this out later. You're right that the test is unrelated. I'll update the branch and that should fix it. |
danielchalmers
left a comment
danielchalmers
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the test.
I see there's still a hover style
Video.mp4
I'll merge after you respond either way - just curious if that's preferred or if it was not simple to change
|
Good point. I personally didn't consider changing other styles besides the cursor icon. I believe it's possible to achieve, but I think different approach might be better. Let me think about it and try it out. |
…thub.com/Qwertyluk/MudBlazor into feature/table-disabled-sort-label-cursor
|
|
@danielchalmers Hover styles should no longer be applied to disabled sorting headers. I achieved this by adding the |
3 participants
Description
Closes #10603
How Has This Been Tested?
Added unit tests and tested it visually.
Type of Changes
The cursor icon for sortable table headers when sorting is enabled:
The cursor icon for sortable table headers when sorting is not enabled:
Checklist
dev).