Skip to content

MudGlobal: Inherit TooltipDefaults from TransitionDefaults#10679

Merged
danielchalmers merged 1 commit intoMudBlazor:devfrom
danielchalmers:global-tooltip-transition
Jan 24, 2025
Merged

MudGlobal: Inherit TooltipDefaults from TransitionDefaults#10679
danielchalmers merged 1 commit intoMudBlazor:devfrom
danielchalmers:global-tooltip-transition

Conversation

@danielchalmers
Copy link
Member

@danielchalmers danielchalmers commented Jan 21, 2025

Description

Altered transition defaults should apply to the tooltip defaults unless the user overrides them.

How Has This Been Tested?

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@danielchalmers danielchalmers added the bug Unexpected behavior or functionality not working as intended label Jan 21, 2025
/// </remarks>
[Parameter]
[Category(CategoryTypes.Tooltip.Appearance)]
public double Duration { get; set; } = MudGlobal.TransitionDefaults.Duration.TotalMilliseconds;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should have been using TooltipDefaults

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.79%. Comparing base (30ae0a0) to head (b0ae9fb).
Report is 28 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10679   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files         426      426           
  Lines       13378    13389   +11     
  Branches     2575     2577    +2     
=======================================
+ Hits        12280    12291   +11     
  Misses        527      527           
  Partials      571      571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielchalmers danielchalmers merged commit 6dfc68c into MudBlazor:dev Jan 24, 2025
7 checks passed
@danielchalmers danielchalmers deleted the global-tooltip-transition branch January 24, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants