MudDropContainer: Fix drag preview "ghost" glitch#10652
Conversation
- Prevent selecting items in the drop container besides the drop items
|
|
Hopefully, we will see if anyone raises an issue. That's the only change I was uncertain of making but it should not be a big impact and I can definitely reproduce the error if it's selectable. |
Hmmm, one case I can see it being useful to be selectable is Kanban board? Tho it seems like even in github it doesn't work well, you can select the first container, but not the others as when you try to do it, it inits the drag action. |
danielchalmers
left a comment
There was a problem hiding this comment.
I'm not that familiar with the drop zone but this seems to work nicely. I suppose for text selection it should be possible to define areas that are excluded from the drag start but maybe that already exists
|
Thanks @Anu6is |
|
I think this change is problematic, since datagrid uses drop container even if you don't have drag and drop enabled, you can't select anything in the datagrid at all, and we don't have intuitive opt out for this logic, and somebody on discord already complained about it. |
|
Maybe we should at least add datagrid to exclusion and remove |
|
Also one moment, always do this in future: rather than in one line, otherwise github will not register the issues and auto close them on merge. |
Reverted the no select in the container. The other two fixes remain. Excluding data grid helps with our component but not if a user wraps something they made in a similar manner. Another option could be adding a SelectContent parameter to the drop container to toggle selection. But for now I think reverting is fine |



Description
Based on various tests, the issue occurs when:
ItemRendererincludes a component withRippleenabledmud-drop-item-preview-startdivChildContentof theMudDropContainerThis fix addresses each above scenario by
mud-ripple:aftercss when nested in amud-drop-itemuser-select: noneto theMudDropContianerandmud-drop-item-preview-startclassNote: This means that general text within the
MudDropContainercan not be selected.However, Buttons, Checkboxes and such are still clickable.
Resolves: #10645
Resolves: #6427
Resolves: #4601
Resolves: #9836
Resolves: #8147
Resolves: #5869
Resolves: #3991
How Has This Been Tested?
Visually
Type of Changes
Checklist
dev).