MudDataGrid: Fix no records found appearance with Virtualize#10552
Merged
ScarletKuro merged 3 commits intoMudBlazor:devfrom Jan 15, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10552 +/- ##
=======================================
Coverage 91.55% 91.56%
=======================================
Files 426 426
Lines 13305 13309 +4
Branches 2565 2565
=======================================
+ Hits 12182 12186 +4
Misses 548 548
Partials 575 575 ☔ View full report in Codecov by Sentry. |
9 tasks
Member
|
@danielchalmers do you think moving: to the DataGrid itself is a correct a decision? |
danielchalmers
approved these changes
Jan 9, 2025
Member
danielchalmers
left a comment
There was a problem hiding this comment.
@danielchalmers do you think moving:
<tr class="mud-table-row"> <td class="mud-table-cell" colspan="1000"> No data </td> </tr>to the DataGrid itself is a correct a decision?
Sure, that pattern is already used several times in MudDataGrid.razor.
|
ScarletKuro
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fix #10524
How Has This Been Tested?
unit | visually
new test :
DataGridNoRecordsContentVirtualizeTest.razornew viewer test :
DataGridVirtualizeServerDataLoadingWithSearchGroupableTest.razorType of Changes
Checklist
dev).Additionnal note :
DataGridVirtualizeServerDataLoadingWithSearchGroupableTest.razorshow grouping problem with Virtualize flag and didn't work - i says didn't work at all with Virtualize -grouping must be done with the full data set and virtualization must do not refer to the same VirtualItemsProvider i guess because it reset actual grouping (set _currentRenderFilteredItemsCache to null)
BTW it didn't work on V7
cache cancellation
when i'm looking for the grouping problem i see that specific case : virtualize component can cancel the current chunk and then return empty result => which clear the grouping (because no data)