MudMenu: Bring style closer to Material Design#10542
MudMenu: Bring style closer to Material Design#10542danielchalmers merged 3 commits intoMudBlazor:devfrom
Conversation
|
@dennisrahmen This is where I mentioned I wanted to reach in your original PR. Do you think it's in a good place? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10542 +/- ##
=======================================
Coverage 91.59% 91.59%
=======================================
Files 426 426
Lines 13298 13297 -1
Branches 2562 2561 -1
=======================================
Hits 12180 12180
Misses 546 546
+ Partials 572 571 -1 ☔ View full report in Codecov by Sentry. |
|
|
@danielchalmers looks great! Did you check when you have icons with different sizes in the same menu? |
I ended up just explicitly removing the ability to change the icon size for the sake of aligning with the standard as it was more trouble than it's worth. Do you know of a use case for varying sizes that will be hurt by this change before final release? @dennisrahmen |
|
Perfect opportunity to reference this #9143 (comment) I don't think that it will have a huge impact, especially now that it is decoupled from the |
Ahaha that's a great reference 😁 Yeah, I think decoupling was definitely the way to go so they can diverge to meet standards better. Do you think list items need any work in addition to this work on the menu items? |
henon
left a comment
There was a problem hiding this comment.
Looking way better now, good job!
That's what I tried to address originally for everything that uses the When you look at the Also at that point I think it would make sense to remove the icon size there as well. |



Description
Closes #10077. Resolves #9097 as an alternative to #9143 after building on top of #10478.
Using materials from:
How Has This Been Tested?
visually
Type of Changes
Before
After
Before
After
Checklist
dev).