Skip to content

MudDataGrid: Add CurrentPageChanged EventHandler to enable binding#10483

Merged
ScarletKuro merged 2 commits intoMudBlazor:devfrom
ZizWing:feature/datagrid-bindable-currentpage
Dec 21, 2024
Merged

MudDataGrid: Add CurrentPageChanged EventHandler to enable binding#10483
ScarletKuro merged 2 commits intoMudBlazor:devfrom
ZizWing:feature/datagrid-bindable-currentpage

Conversation

@ZizWing
Copy link
Contributor

@ZizWing ZizWing commented Dec 19, 2024

Description

Just like #10458 this simply adds an EventHandler matching the CurrentPage property of MudDataGrid. The previous PR did this for MudTable, this is simply a follow-up to match that functionality in MudDataGrid since their setup in this regard is practically identical.

Similarly to before, I opted not to refactor the setter of CurrentPage (it breaks the auto-property guideline) and keep changes to a minimum.

Related issues were already linked in the other PR, should that be repeated here or does that interfere with how GitHub links/autoresolves them?

How Has This Been Tested?

A new unit test has been added.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Dec 19, 2024
@ScarletKuro ScarletKuro requested a review from henon December 19, 2024 11:33
@codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (d69bef1) to head (dc132d0).
Report is 9 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10483      +/-   ##
==========================================
- Coverage   91.59%   91.58%   -0.01%     
==========================================
  Files         426      426              
  Lines       13278    13279       +1     
  Branches     2550     2550              
==========================================
  Hits        12162    12162              
  Misses        546      546              
- Partials      570      571       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

@ScarletKuro ScarletKuro merged commit 2183b65 into MudBlazor:dev Dec 21, 2024
@ZizWing ZizWing deleted the feature/datagrid-bindable-currentpage branch December 21, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants