You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently a work in progress. Not all ActivatorContent has been inspected and replaced where necessary.
Additionally, the documentation should be expanded.
If the ActivationEvent is RightClick or MouseOver, calling context.OpenMenuAsync is not necessary, as these events are handled differently.
If the ActivationEvent is RightClick or MouseOver, calling context.OpenMenuAsync is not necessary, as these events are handled differently.
Small update:
@danielchalmers
MouseOver has special behavior in that it also supports onclick (not specifically left or right), i dont know if that's relevant
Hover opens it temporarily but Click opens it permanently
This means that you actually do need to call context.OpenMenuAsync or context.ToggleMenuAsync (depending on the behavior we want to achieve) when the ActivationEvent is MouseOver.
There are a few open topics:
Currently, on desktop, the behavior is such that if you hover over and click on the activation area while the mouse is hovering over it, the menu will toggle (close). If you click again on the activation area, the menu will open permanently, and you can hover out without it closing. The question is: should we change this behavior? Specifically, should we make it so that on non-touch devices, when you hover and click on the activation area, the menu will not toggle (close) but instead instantly activate the permanent mode?
Should we create a specially named method, such as context.OpenMouseOverMenuAsync? This would allow us to properly document what it does, making it less confusing for the end user to understand which context action to use.
The transient flag on OpenMenuAsync is what decides if it should stay open permanently or not. By default it's false and permanent, but if's true (set during the pointerenter handler) it closes if the pointer leaves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breaking changeThis change will require consumer code updates
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #9800
WIP
How Has This Been Tested?
WIP
Type of Changes
Checklist
dev).