MudMenuItem: Decouple from MudListItem and Change Icon Layout#10478
Merged
henon merged 9 commits intoMudBlazor:devfrom Dec 20, 2024
Merged
MudMenuItem: Decouple from MudListItem and Change Icon Layout#10478henon merged 9 commits intoMudBlazor:devfrom
henon merged 9 commits intoMudBlazor:devfrom
Conversation
github-actions
bot
added
the
breaking change
danielchalmers
changed the title
danielchalmers
changed the title
danielchalmers
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10478 +/- ##
=======================================
Coverage 91.58% 91.59%
=======================================
Files 426 426
Lines 13278 13290 +12
Branches 2550 2555 +5
=======================================
+ Hits 12161 12173 +12
Misses 546 546
Partials 571 571 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Migration Guide:
|
ScarletKuro
approved these changes
Dec 18, 2024
Member
|
Noticed you have some commented code: MudBlazor/src/MudBlazor/Components/Menu/MudMenuItem.razor.cs Lines 26 to 27 in 44b1eff Don't think the policy is allowing commented code if the PR is ready to be merged. |
|
Contributor
|
FYI @dennisrahmen |
henon
changed the title
Contributor
|
Thanks @danielchalmers |
Closed
7 tasks
4 tasks
This was referenced Aug 25, 2025
This was referenced Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MenuItem is no longer based on ListItem internally to allow greater control over behaviour and style. Any dependencies on the list item classes will likely break.
The icon size is now chosen based on whether or not the Dense variant is used. The style is based loosely on the MD2 spec and lays the groundwork for further refinements under #10077.
Resolves #9097
How Has This Been Tested?
unit
Type of Changes
Before, no icons
After, no icons (no change which is intended)
.
Before, mixed icons sizes:
After, can no longer be customized:
Checklist
dev).