Skip to content

MudDataGrid: Align select column and row select behavior#10475

Merged
ScarletKuro merged 3 commits intoMudBlazor:devfrom
Anu6is:10472-MudDataGrid-RespectMultiSelection
Dec 19, 2024
Merged

MudDataGrid: Align select column and row select behavior#10475
ScarletKuro merged 3 commits intoMudBlazor:devfrom
Anu6is:10472-MudDataGrid-RespectMultiSelection

Conversation

@Anu6is
Copy link
Contributor

@Anu6is Anu6is commented Dec 18, 2024

Description

Currently, users can select multiple rows using the SelectColumn checkboxes, regardless of if MultiSelection is enabled or not.

  • Enforce selection behavior based on the value of MultiSelection.
  • Align the behavior of clicking a row and selecting a checkbox.

Resolves #10472

Impact

Users would need to set MultiSelection to true in order to achieve the previous (erroneous?) behavior of selecting multiple rows via the checkboxes. It is possible that this bug may have been utilized as a feature.

How Has This Been Tested?

Visually & unit test

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Dec 18, 2024
@codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (4249257) to head (6e80388).
Report is 4 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev   #10475   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         426      426           
  Lines       13277    13277           
  Branches     2549     2549           
=======================================
  Hits        12152    12152           
  Misses        552      552           
  Partials      573      573

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ScarletKuro ScarletKuro merged commit d69bef1 into MudBlazor:dev Dec 19, 2024
@Yomodo
Copy link
Contributor

Yomodo commented Dec 19, 2024

@ScarletKuro Will there be an interim nuget release or something like that?

I'm still stuck on preview4 because of the MudDataGrid virtualization bug in preview5
which is fixed in preview6 but preview6 has this MudDataGrid selection-bug which is now fixed.

@ScarletKuro
Copy link
Member

ScarletKuro commented Dec 19, 2024

@ScarletKuro Will there be an interim nuget release or something like that?

Maybe when #10467 will be merged I will make a release, as it's critical fix

@Yomodo
Copy link
Contributor

Yomodo commented Dec 26, 2024

@ScarletKuro Will there be an interim nuget release or something like that?

Maybe when #10467 will be merged I will make a release, as it's critical fix

Still hoping Santa will gift us an interim nuget 😃

@ScarletKuro
Copy link
Member

ScarletKuro commented Dec 26, 2024

Still hoping Santa will gift us an interim nuget 😃

Problem is that the nuget is expired and we need the owner to change it.

@Anu6is Anu6is deleted the 10472-MudDataGrid-RespectMultiSelection branch January 22, 2025 13:51
@dependabot dependabot bot mentioned this pull request Aug 1, 2025
Closed
This was referenced Aug 18, 2025
Closed
Merged
@dependabot dependabot bot mentioned this pull request Aug 27, 2025
Merged
@dependabot dependabot bot mentioned this pull request Sep 8, 2025
Closed
@dependabot dependabot bot mentioned this pull request Sep 22, 2025
Closed
This was referenced Oct 5, 2025
Merged
Open
Open
@dependabot dependabot bot mentioned this pull request Nov 3, 2025
Merged
@dependabot dependabot bot mentioned this pull request Nov 12, 2025
Closed
@dependabot dependabot bot mentioned this pull request Jan 3, 2026
Closed
@dependabot dependabot bot mentioned this pull request Jan 11, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScarletKuro ScarletKuro ScarletKuro approved these changes

Assignees

No one assigned

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MudDataGrid: Checkboxes do not remain checked when clicking on a row and SelectOnRowClick = true

3 participants

@Anu6is @Yomodo @ScarletKuro