Conversation
… overlay on popover positioning and excluded MudDialog and Absolute from Section rendering.
…order to match parent instead allowing it to catch everything outside without skipping parent.
github-actions
bot
added
breaking change
|
@danielchalmers I've started this as a draft PR before submitting it for review to others. I know you've been extra busy lately but let me know if you have time to look and it is okay to submit. Additionally this PR/Branch is live on https://Try.ArcTechOnline.Tech though you can't save snippets you can copy/paste code. I tested every Issue listed above. In addition I tested every component on every doc page that used an autocomplete, popover, or overlay. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10446 +/- ##
=======================================
Coverage 91.53% 91.54%
=======================================
Files 418 418
Lines 13228 13231 +3
Branches 2539 2539
=======================================
+ Hits 12108 12112 +4
Misses 547 547
+ Partials 573 572 -1 ☔ View full report in Codecov by Sentry. |
|
Will look soon! Quick note: it would be better if the markup wasn't duplicated inside the SectionContent and outside it |
@versile2 you can look how it was done here https://github.com/MudBlazor/MudBlazor/blob/21e9161b5f724f0295c459dae17af4a8a84e7e69/src/MudBlazor/Components/AppBar/MudAppBar.razor |
|
@ScarletKuro 738ecdb is using tabs instead of spaces in some places |
Yeah, I'm trying to setup it now. I installed windows 11 so it seems VS is using tabs, tho on windows 10 I didn't do any special setup. Since |
|
Should be ok now. It's just weird that @versile2's formatting was this off https://github.com/MudBlazor/MudBlazor/blob/c2c339757b87fc1c7a24f3a3bf9bd76c1486b289/src/MudBlazor/Components/Popover/MudPopoverProvider.razor |
For some reason it would not format that file no matter what I did. |
danielchalmers
left a comment
danielchalmers
left a comment
There was a problem hiding this comment.
Working on my end. One small note
|
|
@versile2 what should we advise users to do in the v8 migration guide? |
Yes, what should go to the v8 migration guide? |
|
I can finally get rid of this: // Workaround for MudMenu's submenu appears on top and not underneath.
ZIndex = new ZIndex {Popover = new ZIndex().AppBar + 1}, |
MudOverlay moved to SectionOutlet with MudPopoverProvider in all cases except Dialogs, Absolute positioned Overlays, and Overlays with child Content. Should have minimal impact unless you have previously used a workaround for Overlay positioning (often used with AutoComplete or Popovers inside of Appbar/Drawer). |
6 participants
Description
Relocates MudOverlay to MudPopoverProvider, the vast majority of the time there will only be one overlay at a given time and it will not be trapped unless the user specifically wants it trapped. Previous behavior is kept for the Dialog, the Drawer, if there is Child Content, and if it is set to Absolute. Adjusted the way autocomplete opens and closes popover to match MudSelect. With this change using SectionOutlet and SectionContent there can never be more than one MudPopoverProvider, Blazor will not allow it. I marked this as a breaking change as there are lots of people who have overridden the behavior of mudautocomplete, popover, and/or overlay. This will change that behavior and location they may need to target.
Fixes #10396
Fixes #10157 without z-index oddities
Fixes #10010
Fixes #9611
Fixes #7196
Fixes #7047 (it was still broken)
Fixes #6600
Fixes #6388
Fixes #5946
Fixes #4961
Fixes #2976
Fixes #9550 (Wasn't padding, it was the way they were done differently at least it's not actually an autocomplete issue)
How Has This Been Tested?
Unit Tests still run, added additional tests to test overlay position and adjusted dozens of tests to use the new positioning as well as fixed any "Viewer" Test that had more than one MudPopoverProvider.
Type of Changes
Checklist
dev).