Skip to content

MudDataGrid: Fix virtualization regression (#10343)#10402

Merged
ScarletKuro merged 1 commit intoMudBlazor:devfrom
Ptipoi-jf:fix/datagrid-virtualize-regression
Dec 8, 2024
Merged

MudDataGrid: Fix virtualization regression (#10343)#10402
ScarletKuro merged 1 commit intoMudBlazor:devfrom
Ptipoi-jf:fix/datagrid-virtualize-regression

Conversation

@Ptipoi-jf
Copy link
Contributor

@Ptipoi-jf Ptipoi-jf commented Dec 7, 2024

Description

Fix: #10343 introduced by #10218, revert from #10361 can be cancelled
Fix: #10338

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

Additionnal notes :

If there is any other related bug, you can try to remove this optimisation

                        @{
                            var resolvedPageItems = new List<IndexBag<T>>(0);
                            // resolve the page items only when used
                            if (!Virtualize || !HasServerData || HasFooter)
                            {
                                resolvedPageItems = CurrentPageItems.Select((item, index) => new IndexBag<T>(index, item))
                                    .ToList();
                            }
                        }

with

                        @{ 
                            var resolvedPageItems = CurrentPageItems.Select((item, index) => new IndexBag<T>(index, item))
                                .ToList();
                        }

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Dec 7, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2024

@ScarletKuro ScarletKuro changed the title Datagrid: fix regression about virtualization (#10343) MudDataGrid: Fix virtualization regression (#10343) Dec 8, 2024
@ScarletKuro ScarletKuro merged commit 7f59078 into MudBlazor:dev Dec 8, 2024
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8.0.0-preview.5 DataGrid Virtualization Bug 8.0.0-preview.5 datagrid bug

2 participants