Skip to content

Cookie Consent CSS: Fixes the Cookie Consent Popup from Blocking the UI#10368

Merged
danielchalmers merged 1 commit intoMudBlazor:devfrom
mouse0270:fix/cookie-consent-ui-blocking
Dec 1, 2024
Merged

Cookie Consent CSS: Fixes the Cookie Consent Popup from Blocking the UI#10368
danielchalmers merged 1 commit intoMudBlazor:devfrom
mouse0270:fix/cookie-consent-ui-blocking

Conversation

@mouse0270
Copy link
Contributor

The Cookie Consent Dialog Container blocks the ui from being interacted with even though the content of the dialog is restricted to a max width of 48rem;

Description

I have updated the following file MudBlocks.Docs/Styles/components/_consent.scss to do the following

.cookie-consent-container {
  pointer-events: none;
}
.cookie-consent {
  pointer-events: all;
}

This will allow users to click though the area of .cookie-consent-container but still interact with .cookie-consent content.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

The content to the sides of the cookie consent are now able to be interacted with.
image

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Unexpected behavior or functionality not working as intended PR: needs review labels Dec 1, 2024
@codecov
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.43%. Comparing base (6175363) to head (639d016).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10368   +/-   ##
=======================================
  Coverage   91.42%   91.43%           
=======================================
  Files         418      418           
  Lines       13226    13226           
  Branches     2538     2538           
=======================================
+ Hits        12092    12093    +1     
  Misses        554      554           
+ Partials      580      579    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2024

Copy link
Member

@danielchalmers danielchalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks!

@danielchalmers danielchalmers merged commit 3f9618b into MudBlazor:dev Dec 1, 2024
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Unexpected behavior or functionality not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants