MudAutocomplete, MudSelect: Allow popover customization and add scroll events#10327
MudAutocomplete, MudSelect: Allow popover customization and add scroll events#10327ScarletKuro merged 12 commits intoMudBlazor:devfrom
Conversation
src/MudBlazor.UnitTests.Viewer/TestComponents/Select/SelectScrollDrawerTest.razor
Outdated
Show resolved
Hide resolved
src/MudBlazor.UnitTests.Viewer/TestComponents/Select/SelectScrollDrawerTest.razor
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10327 +/- ##
==========================================
- Coverage 91.54% 91.48% -0.07%
==========================================
Files 415 416 +1
Lines 13017 13054 +37
Branches 2457 2473 +16
==========================================
+ Hits 11917 11943 +26
+ Misses 549 548 -1
- Partials 551 563 +12 ☔ View full report in Codecov by Sentry. |
|
What about merging these into a single parameter public struct DropdownBehavior {
public bool Fixed { get; set; }
public OverflowBehavior OverflowBehavior { get; set; } = OverflowBehavior.FlipOnOpen;
}Alternative names I think for this very specialized configuration preparing the settings object in In addition to that the parameters intended for the popover are now intuitively named which is not the case when they are directly exposed in MudAutocomplete on their own. I when first seeing this I wasn't sure what |
|
Please name it |
…em into DropdownBehavior property.
|
Sorry for being a PITA, just think DropdownSettings would be best (no capitalization of Down) |
Well I'll be a monkey's uncle! Give me 5. |
|
and maybe 5 more, have to write unit tests |
|
Let me know if you want any additional changes, I hear PopoverSettings is hot right now :) |
henon
left a comment
There was a problem hiding this comment.
LGTM, thanks for your patience ;). @ScarletKuro you may merge this if you agree with the changes.
The original problem that I initially reported on discord is fixed, but I see that in Edge if you open a very high inspector, this part is sticking out: |
I'm sure it is, probably related to appbar.razor which I had to change for the new properties so I don't see a problem with adding it to this PR. give me a few to confirm and I'll submit if I'm correct. |
|
Actually no, it all appears to be working by design. I can only see the overlap if I zoom to 200% and browser zoom can be odd anyways. I can replicate on chrome if I zoom high enough (500%), Same with firefox (220%). Unless there is some other way to replicate. |
Hmm weird, I don't need to zoom anything. I have 2k monitor and all I have to do is to open inspector on like half of the screen size for it to stick out. |
|
@ScarletKuro it's an old issue #8657 |
Ok, lets merge then. |






Description
Allow MudSelect and MudAutocomplete to pass Fixed and OverflowBehavior to the contained popover. Defaults are the same as before, just now it can be overridden if need be.
Additionally, add scroll events on connect for parents with scrollable containers
Resolves #8656
Resolves #10325
Resolves doc page where there is a floating component containing a popover by setting the AutoComplete to Fixed="true"
How Has This Been Tested?
Visual Tests
Type of Changes
Checklist
dev).