Revert "Popover: Hide all element overflow"#10308
Merged
danielchalmers merged 1 commit intodevfrom Nov 22, 2024
Merged
Conversation
This reverts commit e571374.
|
ScarletKuro
added
bug
LLauter
pushed a commit
to cannellamedia/MudBlazor
that referenced
this pull request
Dec 16, 2024
This was referenced Aug 18, 2025
This was referenced Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #9993
Resolves #10306. Certain elements (tooltip arrow) use
::afterwhich is not included in the popover overflow.Hiding the overflow in a sweeping way like this doesn't seem common in other libraries either.
Instead I'll focus on clipping it in the source itself, like the shadow from a button in the original instance, instead of applying a band aid over it by hiding all overflow when there are legitimate uses for it.