Skip to content

MudSnackbar: Move Icon configs to CommonSnackbarOptions#10285

Merged
ScarletKuro merged 3 commits intoMudBlazor:devfrom
Anu6is:Snackbar
Nov 22, 2024
Merged

MudSnackbar: Move Icon configs to CommonSnackbarOptions#10285
ScarletKuro merged 3 commits intoMudBlazor:devfrom
Anu6is:Snackbar

Conversation

@Anu6is
Copy link
Contributor

@Anu6is Anu6is commented Nov 20, 2024

Description

Move Icon configs from SnackbarOptions to CommonSnackbarOptions.
This allows the Icons to be set globally via SnackbarConfigurations

Resolves #10284

How Has This Been Tested?

Unit tests and visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library PR: needs review labels Nov 20, 2024
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.55%. Comparing base (759f814) to head (b4ebc4b).
Report is 13 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10285      +/-   ##
==========================================
+ Coverage   91.52%   91.55%   +0.02%     
==========================================
  Files         414      414              
  Lines       12989    12995       +6     
  Branches     2452     2452              
==========================================
+ Hits        11888    11897       +9     
+ Misses        555      552       -3     
  Partials      546      546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@Etzix Etzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! That was speedy too, thanks. :)

@ScarletKuro ScarletKuro merged commit 00eb472 into MudBlazor:dev Nov 22, 2024
@Anu6is Anu6is deleted the Snackbar branch November 22, 2024 15:18
@henon henon changed the title Snackbar: Move Icon configs to CommonSnackbarOptions MudSnackbar: Move Icon configs to CommonSnackbarOptions Nov 23, 2024
LLauter pushed a commit to cannellamedia/MudBlazor that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adds a new feature or enhances existing functionality (not fixing a defect) in the main library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Snackbar: Ability to set default icons per severity globally.

4 participants